Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] fix Notification UI tests #4212

Merged
merged 2 commits into from
Oct 20, 2020
Merged

[tests-only] fix Notification UI tests #4212

merged 2 commits into from
Oct 20, 2020

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Oct 20, 2020 •
edited
Loading

Description

  1. fix the issue that causes these tests to fail
  2. add missing tests to drone, so that they will not be forgotten when the feature is finished
  3. regroup tests to make CI faster

Related Issue

part of owncloud/ocis#518

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@individual-it individual-it self-assigned this Oct 20, 2020
@individual-it individual-it mentioned this pull request Oct 20, 2020
Closed
2 tasks
@individual-it individual-it merged commit 60b2484 into master Oct 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the notificationTests branch October 20, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@individual-it individual-it

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@individual-it @phil-davis