Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Chunk 2 #3083

Open
wants to merge 184 commits into
base: unstable
Choose a base branch
from

Conversation

yougotwill
Copy link
Collaborator

@yougotwill yougotwill commented Apr 24, 2024

Code review has been done on Will’s fork:
yougotwill#43

Edit: Chunk 1 has been merged so we can do the final review here

moved some parts into the leftpanesectionheader
this will replace the sessionideditable eventually still needs error handling etc
only show button when users enters something
created new ActionRow component
since we swapped some toast messages for input messages
updated error correction to 25%
updated account id and recovery password qr codes with logos
qr code logos can now be svgs for better rendering performance
some config messages are not handled correctly and we need to know why
disabled conversation header functionality
…s to data urls

we no longer need to update the svgs manually
prefer to import it explcitly when needed
otherwise appimages fail to build
heading for unamed contacts is #, groups go above note to self, trust in the sql query
@yougotwill yougotwill marked this pull request as ready for review June 17, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant