Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Chunk 2 #3083

Open
wants to merge 184 commits into
base: unstable
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
184 commits
Select commit Hold shift + click to select a range
38c3903
refactor: leftpanemessagesection is now a functional component
yougotwill Apr 22, 2024
e965194
feat: removed overlayheader
yougotwill Apr 22, 2024
30118c3
feat: added monospace textarea support to sessioninput
yougotwill Apr 22, 2024
64bd7b8
fix: restore copyOpenGroupURL key
yougotwill Apr 22, 2024
2f2c214
feat: added some localised strings the create convo screens
yougotwill Apr 23, 2024
4decf22
feat: improved error messaging when starting a new message
yougotwill Apr 23, 2024
20766c4
feat: added conversation id to debugmessageinfo
yougotwill Apr 23, 2024
2d7b957
feat: closed group pubkeys cannot be used to create new messages
yougotwill Apr 23, 2024
edb9a24
feat: new message description and added zendesk link
yougotwill Apr 23, 2024
31ef730
fix: correct type for style prop on SessionInput
yougotwill Apr 23, 2024
2a75a71
feat: update continue button styles
yougotwill Apr 23, 2024
093da15
feat: updated style for choose action overlay
yougotwill Apr 24, 2024
cd3bc72
feat: updated ContactsListWithBreaks to show text when empty
yougotwill Apr 24, 2024
76f5ad1
feat: consolidate remaining sessioneditable instances
yougotwill Apr 24, 2024
551ee42
fix: cleaned up unused localised strings
yougotwill Apr 26, 2024
ab093ff
feat: replace react-qr-svg with react-qrcode-logo
yougotwill Apr 26, 2024
0d3c058
feat: new sessionqrcode component
yougotwill Apr 26, 2024
04dc4fe
fix: the modal header now always centers content correctly
yougotwill Apr 26, 2024
3cb0255
feat: compressed qr logo images
yougotwill Apr 26, 2024
8a4e5d5
fix: add background colors to logos so the background matches
yougotwill Apr 26, 2024
44cc859
fix: saved qr codes will be black and white by default
yougotwill Apr 30, 2024
dd7f13e
feat: invite a friend screen is mostly done
yougotwill May 1, 2024
2b95e6a
feat: session input styles are now separated into per styling
yougotwill May 1, 2024
aac90cc
feat: finished invite a friend overlay
yougotwill May 3, 2024
d4a8b55
Merge branch 'unstable' into feat/ses-825/onboarding2
yougotwill May 3, 2024
18ef4a6
feat: log dumps for debugging restoring accounts
yougotwill May 3, 2024
6e3df83
fix: overlayInvite errors
yougotwill May 3, 2024
c54b4d2
fix: was logging the push but not the dump
yougotwill May 6, 2024
98f5286
fix: revert always on dump logging
yougotwill May 6, 2024
d6ad37e
feat: show description text when making a message request
yougotwill May 6, 2024
d74edc5
feat: disable composition for outgoing message requests
yougotwill May 6, 2024
8ae6dab
feat: hide message preview in convo list item for outgoing requests
yougotwill May 6, 2024
20c0453
fix: dont disable text area for outgoing message requests
yougotwill May 6, 2024
b6d5c24
feat: added updated group icon
yougotwill May 6, 2024
d346f28
feat: extracted password to new modal
yougotwill May 7, 2024
3e1bf04
fix: remove extra window
yougotwill May 7, 2024
7d89097
fix: usemount imports have to be specific
yougotwill May 8, 2024
01bdc6e
fix: make sure qr code fits the canvas contents
yougotwill May 8, 2024
fd722d1
feat: swapped out seed modal for settings category page
yougotwill May 8, 2024
2738510
fix: updated messageRequestPendingDescription copy with full stop
yougotwill May 9, 2024
a629fa5
feat: created new recovery phrase ui and qr code with toggling
yougotwill May 9, 2024
bb27570
fix: make qr code update correctly if theme changes
yougotwill May 10, 2024
2eca144
fix: improve qr code icon
yougotwill May 10, 2024
705d962
fix: recovery password text now uses primary text color for light modes
yougotwill May 10, 2024
bddac7a
feat: added icons to all settings categories
yougotwill May 10, 2024
862b834
feat: added hide password permenantly ui
yougotwill May 14, 2024
7cd7dea
fix: brand logo in onboard header should not block buttons
yougotwill May 14, 2024
51534d4
feat: added new hide recovery password setting
yougotwill May 14, 2024
fb3a87a
feat: added new hide recovery password modal
yougotwill May 14, 2024
51a0fa3
fix: removed SeedModal code
yougotwill May 14, 2024
39dc918
fix: open recovery password settings page from left banner
yougotwill May 14, 2024
67f2763
Merge branch 'unstable' into feat/ses-825/onboarding2
yougotwill May 14, 2024
452b1b8
fix: use localised strings for qr password toggle button
yougotwill May 14, 2024
1b6abb8
feat: restrict importing useMount from react-use directly
yougotwill May 15, 2024
284880e
feat: added mocharc.json
yougotwill May 15, 2024
dfd4631
feat: updated styled components and typings
yougotwill May 15, 2024
f245f6d
fix: added missing & selector to all pseudo events
yougotwill May 15, 2024
9dce5c1
fix: repair global styling after styled upgrade improved match system…
yougotwill May 15, 2024
df515ca
feat: improved zoom slider behaviour and styling
yougotwill May 15, 2024
192cbd2
feat: added react testing library and chai dom
yougotwill May 15, 2024
221efaa
Merge branch 'unstable' into feat/ses-968/standardise_profile_picture
yougotwill May 16, 2024
aa4a42c
fix: sessioninput color should be danger when there is an error
yougotwill May 16, 2024
d662b7d
fix: use recoveryPasswordOutline for light themes
yougotwill May 16, 2024
9bf7126
fix: replace setAccountPasswordTitle with lockApp string
yougotwill May 16, 2024
f3add6f
fix: use correct hero image
yougotwill May 16, 2024
96f0585
fix: welcome message should use text-primary-color for light themes
yougotwill May 17, 2024
51a36e6
fix: repair placeholder selectors
yougotwill May 17, 2024
6db6a1f
fix: resolve cyclic imports with LokiProfile and MessageResultProps
yougotwill May 20, 2024
3f3c2f9
fix: resolve cyclic import with outgoing message type
yougotwill May 20, 2024
1d5c2de
feat: added custom render function for react testing library
yougotwill May 20, 2024
55efa4a
feat: addec typings for jsdom
yougotwill May 20, 2024
b13e907
fix: resolve cyclic imports in avatarplaceholder
yougotwill May 20, 2024
523c954
feat: added datatestids to avatarplaceholder and member placeholder
yougotwill May 20, 2024
7d4b961
feat: added print functions for react render results and html elements
yougotwill May 20, 2024
121d968
feat: add component name support to printing functions
yougotwill May 20, 2024
91d1229
feat: made good progress on avatar place holder unit test
yougotwill May 20, 2024
bc5615e
feat: test for correct background color order is done
yougotwill May 21, 2024
0166708
fix: there is already a unit test for initials
yougotwill May 21, 2024
ccee835
feat: updated profile modal with style changes
yougotwill May 22, 2024
5e28504
feat: added flex gap support to Flex component
yougotwill May 22, 2024
5765128
fix: make sure larger modals fit the minimum window size
yougotwill May 22, 2024
f726fa5
fix: pass through events to onClose for modals
yougotwill May 22, 2024
33b68a2
feat: created copy to clipboard button
yougotwill May 22, 2024
681f488
feat: added --font-size-xl
yougotwill May 22, 2024
e5625ca
feat: updated SessionInput to support multiple font sizes
yougotwill May 22, 2024
08487bc
feat: spinner can now set width and height surrounding the svg
yougotwill May 22, 2024
698eb14
fix: rename fontSize and disableOnBlur on Sessioninput
yougotwill May 22, 2024
94abe60
feat: added SessionInput to Profile Modal
yougotwill May 22, 2024
4ae133b
feat: only center textarea placeholder text and not value in sessioni…
yougotwill May 23, 2024
a159616
feat: added filters to convo and contact query
yougotwill May 23, 2024
6f7001e
fix: contact list should not be case sensitive
yougotwill May 23, 2024
6c65c41
feat: added subtitle header to search results
yougotwill May 23, 2024
71cc46d
feat: search results are now sorted alphabetically without case sensi…
yougotwill May 23, 2024
8918598
fix: clear search when change left pane modes
yougotwill May 23, 2024
26abb2b
fix: note to self always appears when there is a match regardless of …
yougotwill May 23, 2024
1e815f6
fix: show no results text when search finds nothing
yougotwill May 23, 2024
521938b
fix: hide message preview for contact during search
yougotwill May 23, 2024
cfc7d33
fix: message search results will use shortened pubkeys for authors
yougotwill May 23, 2024
7d79114
fix: borders on member list items and session radio
yougotwill May 23, 2024
f68fc68
feat: improved search for create group
yougotwill May 23, 2024
fe64b26
feat: improved about screen info
yougotwill May 24, 2024
17250a4
fix: reset right panel when we swap conversations
yougotwill May 24, 2024
6039d9f
feat: fixed update group name error and session recording light anima…
yougotwill May 24, 2024
8271a65
fix: typing animation alignment inside of the messages list
yougotwill May 24, 2024
e4b2798
feat: updated empty message image, typing animation and right panel s…
yougotwill May 24, 2024
6477d73
feat: updated onion status and spinner aimations
yougotwill May 24, 2024
e6a2694
feat: updated message highlight durations
yougotwill May 24, 2024
7349e27
fix: prevent the buttons from flashing when the app starts
yougotwill May 24, 2024
06b4ee0
feat: updated onboarding container and progress bar
yougotwill May 24, 2024
afca070
feat: added copy to clipboard icon button
yougotwill May 24, 2024
48fe7b4
fix: resolve outstanding react-use imports
yougotwill May 24, 2024
b74de3f
fix: quote icons were not appearing if media failed to create a preview
yougotwill May 24, 2024
cc92d17
feat: update invite a friend iniital string
yougotwill May 24, 2024
0a56653
feat: sorted messages.json keys
yougotwill May 24, 2024
2e2f526
feat: added aria label support to buttons
yougotwill May 24, 2024
4507669
feat: added aria labels ot tos buttons in modal
yougotwill May 24, 2024
293a733
feat: account creation flow done
yougotwill May 27, 2024
d14024d
feat: account restoration flow done
yougotwill May 27, 2024
341fa8b
feat: recovery password settings flow done
yougotwill May 27, 2024
2fedce1
feat: invite a friend flow done
yougotwill May 27, 2024
93d1a9d
feat: profile modal flow done
yougotwill May 27, 2024
0f89b11
fix: revert naming convo render functions as components
yougotwill May 27, 2024
aa87675
feat: added aria label to edit profile qr code
yougotwill May 27, 2024
273fc42
feat: session input show hide button improvments
yougotwill May 27, 2024
4174ed5
fix: resolve typos
yougotwill May 27, 2024
6f77b9a
Merge branch 'unstable' into feat/ses-825/onboarding2
yougotwill May 27, 2024
22ad152
fix: remove duplicate debug key
yougotwill Jun 5, 2024
8705fdd
fix: isEmpty is not needed for searchTerm
yougotwill Jun 5, 2024
8e5ac58
fix: properly type button and input ref
yougotwill Jun 5, 2024
111541f
fix: members list in the group overlay doesnt need a set bg color
yougotwill Jun 5, 2024
db7fba0
fix: remove extra className prop
yougotwill Jun 5, 2024
1a13839
fix: properly type send message input reference
yougotwill Jun 5, 2024
2906b32
fix: use input ref for password value instead of document lookup on p…
yougotwill Jun 5, 2024
3b90d7d
fix: replace keyup event listener with usekey hook
yougotwill Jun 5, 2024
d7a874d
fix: specify seconds in onion status glow duration comment
yougotwill Jun 5, 2024
edeed6e
fix: separate p tag styles into a component from styledprofilename
yougotwill Jun 5, 2024
bb48971
fix: ses-2087 recovery password banner heading is too large
yougotwill Jun 7, 2024
d6544ef
fix: ses-2089 update tos datatestid to open-url to match other platforms
yougotwill Jun 7, 2024
d0a40e4
fix: prevent font swap on first load
yougotwill Jun 7, 2024
692f1f5
fix: updated deblug log to use new font variable
yougotwill Jun 7, 2024
69f4fd2
feat: added heading component
yougotwill Jun 7, 2024
506bdbf
fix: replace convo list render functions with components
yougotwill Jun 7, 2024
16539a1
feat: updated hero image
yougotwill Jun 7, 2024
c20bda4
fix: improved global window types for persistStore and inboxStore
yougotwill Jun 7, 2024
4f44a7a
feat: refactor theme state
yougotwill Jun 7, 2024
819d67a
fix: improvements to closedGroupOverlay including virtualize member list
yougotwill Jun 7, 2024
b938d2a
fix: use i18n for continue button aria label
yougotwill Jun 7, 2024
8d8a25a
fix: remove commented css on spinner
yougotwill Jun 7, 2024
1e16be1
fix: use i18n for aria labels on the enter display name button
yougotwill Jun 7, 2024
7b634df
fix: sanitizeDisplayNameOrToast setDisplayNameError to onDisplayNameE…
yougotwill Jun 7, 2024
87fb386
fix: isSubtitle eval in search section header moved to parent
yougotwill Jun 7, 2024
fb68af9
fix: no need for reactnode or string type
yougotwill Jun 7, 2024
268266d
fix: pick keys for icon prop in setting list item title since we dont…
yougotwill Jun 7, 2024
59e6074
fix: since the pass hash is in the items table we can call it from st…
yougotwill Jun 7, 2024
db7355e
fix: about window is now resizable
yougotwill Jun 7, 2024
11b3a0e
feat: upgraded react-qrcode-logo to v3
yougotwill Jun 11, 2024
64d4712
feat: updated shield icon and default colors
yougotwill Jun 11, 2024
64b98a7
feat: added motion props to AnimatedFlex
yougotwill Jun 11, 2024
b459bf9
fix: generate colors for the QR code in a hook that also converts svg…
yougotwill Jun 12, 2024
5e3742e
fix: resolve colors in convertIconToImageURL for qr code
yougotwill Jun 12, 2024
b102a06
fix: first load flicker on qr code
yougotwill Jun 12, 2024
5df14e7
fix: pass resoled colors to session icon on first render
yougotwill Jun 12, 2024
d1a06a9
feat: option to save qr codes with no colors by default
yougotwill Jun 12, 2024
903cfcb
fix: added skinny brand icon instead of messing with ratios
yougotwill Jun 12, 2024
cdc147c
fix: clean wip logs
yougotwill Jun 12, 2024
83a57a3
fix: move shortcuts back into edit profile
yougotwill Jun 12, 2024
f5cd3ba
fix: move left pane header label into a function
yougotwill Jun 12, 2024
cf34db5
feat: added new hot key hook since useKey doesnt ignore special keys
yougotwill Jun 12, 2024
9e9fffd
fix: name showHide button props more explcitly
yougotwill Jun 12, 2024
0a6b0d6
fix: cleanup
yougotwill Jun 12, 2024
8454a67
chore: left comment to use GenericWrapperActions.makeDump once it has…
yougotwill Jun 12, 2024
2dbcfe5
fix: remove unecessary length check on idsWithDisplayNames
yougotwill Jun 12, 2024
da64ee7
fix: dont export react testing library from renderComponent
yougotwill Jun 12, 2024
b219a85
fix: suggest window log stubbing if it's not working when printing re…
yougotwill Jun 12, 2024
301af68
fix: single line linux target in package json
yougotwill Jun 12, 2024
5cd7262
fix: search now works correctly and we include groups again
yougotwill Jun 13, 2024
8915971
fix: more review feedback
yougotwill Jun 14, 2024
3b17e08
fix: more review feedback part 2
yougotwill Jun 14, 2024
f6ed33d
Merge branch 'unstable' into feat/ses-825/onboarding2
yougotwill Jun 17, 2024
b40cf49
Merge branch 'unstable' into feat/ses-825/onboarding2
yougotwill Jun 28, 2024
9264aa7
fix: correct admin crown color
yougotwill Jun 28, 2024
bf218f0
fix: play pause button in audio attachment
yougotwill Jun 28, 2024
009795e
feat: migrated lightbox to modal state
yougotwill Jun 28, 2024
490e495
feat: click on qr codes now opens the lightbox
yougotwill Jun 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: more review feedback part 2
  • Loading branch information
yougotwill committed Jun 14, 2024
commit 3b17e08ea6a0194b25385210189d1c6d4fc35e7f
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@
"ts/**/*.js",
"ts/*.js",
"!dist/**",
"stylesheets/fonts.css",
"stylesheets/dist/*",
"!js/register.js",
"preload.js",
Expand Down
2 changes: 2 additions & 0 deletions ts/components/buttons/CopyToClipboardButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ export const CopyToClipboardIcon = (props: CopyToClipboardIconProps & { copyCont
return (
<SessionIconButton
aria-label={'copy to clipboard icon button'}
padding="0"
margin="0"
{...props}
iconType={'copy'}
onClick={onClick}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import styled from 'styled-components';
import { MessageInfoLabel } from '.';
import { useConversationUsername } from '../../../../../../hooks/useParamSelector';
import { isDevProd } from '../../../../../../shared/env_vars';
import { Avatar, AvatarSize, CrownIcon } from '../../../../../avatar/Avatar';
import { Flex } from '../../../../../basic/Flex';
import { CopyToClipboardIcon } from '../../../../../buttons';

const StyledFromContainer = styled.div`
display: flex;
Expand Down Expand Up @@ -38,9 +41,20 @@ export const MessageFrom = (props: { sender: string; isSenderAdmin: boolean }) =
const profileName = useConversationUsername(sender);
const from = window.i18n('from');

const isDev = isDevProd();

return (
<StyledMessageInfoAuthor>
<MessageInfoLabel>{from}</MessageInfoLabel>
<Flex container={true} justifyContent="flex-start" alignItems="flex-start">
<MessageInfoLabel>{from}</MessageInfoLabel>
{isDev ? (
<CopyToClipboardIcon
iconSize={'medium'}
copyContent={`${profileName} ${sender}`}
margin={'0 0 0 var(--margins-xs)'}
/>
) : null}
</Flex>
<StyledFromContainer>
<StyledAvatar>
<Avatar size={AvatarSize.M} pubkey={sender} onAvatarClick={undefined} />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { isDevProd } from '../../../../../../shared/env_vars';
import { useSelectedConversationKey } from '../../../../../../state/selectors/selectedConversation';
import { Flex } from '../../../../../basic/Flex';
import { SpacerSM } from '../../../../../basic/Text';
import { CopyToClipboardIcon } from '../../../../../buttons';

export const MessageInfoLabel = styled.label<{ color?: string }>`
font-size: var(--font-size-lg);
Expand Down Expand Up @@ -50,11 +51,22 @@ type LabelWithInfoProps = {
onClick?: () => void;
};

const isDev = isDevProd();

export const LabelWithInfo = (props: LabelWithInfoProps) => {
return (
<LabelWithInfoContainer title={props.title || undefined} onClick={props.onClick}>
<MessageInfoLabel color={props.labelColor}>{props.label}</MessageInfoLabel>
<MessageInfoData color={props.dataColor}>{props.info}</MessageInfoData>
<Flex container={true} justifyContent="flex-start" alignItems="flex-start">
<MessageInfoData color={props.dataColor}>{props.info}</MessageInfoData>
{isDev ? (
<CopyToClipboardIcon
iconSize={'medium'}
copyContent={props.info}
margin={'0 0 0 var(--margins-xs)'}
/>
) : null}
</Flex>
</LabelWithInfoContainer>
);
};
Expand Down
2 changes: 2 additions & 0 deletions ts/components/dialog/EnterPasswordModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,14 @@ export const EnterPasswordModal = (props: EnterPasswordModalProps) => {
const passwordValue = passwordInputRef.current?.value;
if (!passwordValue) {
ToastUtils.pushToastError('enterPasswordErrorToast', window.i18n('noGivenPassword'));

return;
}

const isPasswordValid = matchesHash(passwordValue as string, passwordHash);
if (passwordHash && !isPasswordValid) {
ToastUtils.pushToastError('enterPasswordErrorToast', window.i18n('invalidPassword'));

return;
}

Expand Down
Loading