Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major changes to data creation and connection #229

Merged
merged 30 commits into from
Jan 9, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c1b725a
reworking Connection
julorenz Dec 23, 2021
941765d
linting
julorenz Dec 23, 2021
d0f51dc
colocating test ressources
julorenz Dec 25, 2021
1a0179f
linting
julorenz Dec 29, 2021
3f2e7a9
fixing tests ModularPlantManager
julorenz Dec 29, 2021
1554a03
updating files
julorenz Jan 2, 2022
93b4f9e
fix testing fix
julorenz Jan 4, 2022
19225b9
fixing issues and doku
julorenz Jan 4, 2022
e260a8e
refactoring feedbackMonitoringDA
julorenz Jan 4, 2022
85b768e
refactoring interlockDA
julorenz Jan 4, 2022
9946748
refactoring limitMonitoringDA
julorenz Jan 4, 2022
907d0be
refactoring OpModeDA
julorenz Jan 4, 2022
2331052
refactoring OSLevelDA
julorenz Jan 4, 2022
c26ef74
refactoring ResetDA
julorenz Jan 4, 2022
f5fea74
refactoring ScaleSettingsDA
julorenz Jan 4, 2022
d417bf2
refactoring ServiceOpModeDA
julorenz Jan 4, 2022
8e6c6d8
refactoring ServiceSourceModeDA
julorenz Jan 4, 2022
4743d87
refactoring SourceModeDA
julorenz Jan 4, 2022
862b6ce
refactoring UnitSettingsDA
julorenz Jan 4, 2022
f342730
refactoring valueLimitationDA
julorenz Jan 4, 2022
01ddd90
adding Handshake sequence
julorenz Jan 4, 2022
76c90f4
fixing rename of unitController
julorenz Jan 4, 2022
7dc1325
final adjustment to baseFunctions
julorenz Jan 4, 2022
edfe230
refactoring pimad parts
julorenz Jan 4, 2022
00f834d
updating files and tests
julorenz Jan 8, 2022
6fb21a7
linting
julorenz Jan 8, 2022
60fe06b
updating index.ts
julorenz Jan 8, 2022
e4511df
updating packages regarding ts version and linting
julorenz Jan 8, 2022
c07d854
updating api
julorenz Jan 9, 2022
b70dff1
Merge branch 'coreUpdate' into update/opcuaConnection
julorenz Jan 9, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactoring SourceModeDA
  • Loading branch information
julorenz committed Jan 4, 2022
commit 4743d87a01bfdf60cf16ef02a7788817dc1e6644
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
'https://plantuml.com/class-diagram
!include ../_extensions/wqcDA/WQC.puml
!include ../_extensions/opMode/OpModeController.puml
!include ../_extensions/serviceSourceModeDA/ServiceSourceModeController.puml
!include ../_extensions/serviceSourceMode/ServiceSourceModeController.puml
class ServiceControl{
+ readonly communication!: ServiceControlRuntime
+ readonly wqc: WQC
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
!include OSLevel/OSLevel.puml
!include resetDA/Reset.puml
!include scaleSettingsDA/ScaleSettings.puml
!include serviceSourceModeDA/ServiceSourceModeController.puml
!include serviceSourceMode/ServiceSourceModeController.puml
!include sourceModeDA/SourceModeController.puml
!include unitDA/UnitSettings.puml
!include valueLimitationDA/ValueLimitation.puml
Expand All @@ -48,7 +48,7 @@ DataAssemblyController "0..1" o-- OSLevel
DataAssemblyController "0..1" o-- Reset
DataAssemblyController "0..1" o-- ScaleSettingDA
DataAssemblyController "0..1" o-- ServiceSourceMode
DataAssemblyController "0..1" o-- SourceModeDA
DataAssemblyController "0..1" o-- SourceMode
DataAssemblyController "0..1" o-- UnitDA
DataAssemblyController "0..1" o-- ValueLimitationDA
DataAssemblyController "0..1" o-- WQCDA
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export * from './opMode/OpMode';
export * from './osLevel/OSLevel';
export * from './reset/Reset';
export * from './scaleSettings/ScaleSettings';
export * from './sourceModeDA/SourceModeController';
export * from './sourceMode/SourceModeController';
export * from './unitDA/UnitSettings';
export * from './valueLimitationDA/ValueLimitation';
export * from './wqcDA/WQC';
Original file line number Diff line number Diff line change
Expand Up @@ -26,32 +26,32 @@
import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import {MockupServer} from '../../../../_utils';
import {SourceModeDAMockup} from './SourceModeDA.mockup';
import {SourceModeMockup} from './SourceMode.mockup';
import {OpcUaConnection} from '../../../connection';
import {ServiceSourceMode, SourceMode} from '@p2olab/polaris-interface';

chai.use(chaiAsPromised);
const expect = chai.expect;


describe('SourceModeDAMockup', () => {
describe('SourceModeMockup', () => {
describe('static', () => {
let mockupServer: MockupServer;
beforeEach(async()=>{
mockupServer = new MockupServer();
await mockupServer.initialize();
});

it('should create SourceModeDAMockup', async () => {
const mockup= new SourceModeDAMockup(mockupServer.nameSpace,
it('should create SourceModeMockup', async () => {
const mockup= new SourceModeMockup(mockupServer.nameSpace,
mockupServer.rootObject, 'Variable');
expect(mockup).to.not.be.undefined;
});

it('getSourceModeMockupReferenceJSON()', () => {
const mockup = new SourceModeDAMockup(mockupServer.nameSpace,
const mockup = new SourceModeMockup(mockupServer.nameSpace,
mockupServer.rootObject, 'Variable');
const json = mockup.getSourceModeDAInstanceMockupJSON() as any;
const json = mockup.getSourceModeInstanceMockupJSON() as any;
expect(Object.keys(json).length).to.equal(7);
expect(json.SrcChannel).to.not.be.undefined;
expect(json.SrcManAut).to.not.be.undefined;
Expand All @@ -65,14 +65,14 @@ describe('SourceModeDAMockup', () => {
describe('dynamic', () => {

let mockupServer: MockupServer;
let mockup: SourceModeDAMockup;
let mockup: SourceModeMockup;
let connection: OpcUaConnection;

beforeEach(async function () {
this.timeout(10000);
mockupServer = new MockupServer();
await mockupServer.initialize();
mockup = new SourceModeDAMockup(mockupServer.nameSpace, mockupServer.rootObject, 'Variable');
mockup = new SourceModeMockup(mockupServer.nameSpace, mockupServer.rootObject, 'Variable');
await mockupServer.start();
connection = new OpcUaConnection();
connection.initialize({endpoint: mockupServer.endpoint});
Expand Down Expand Up @@ -125,14 +125,14 @@ describe('SourceModeDAMockup', () => {
describe('dynamic, srcChannel is true', () => {

let mockupServer: MockupServer;
let mockup: SourceModeDAMockup;
let mockup: SourceModeMockup;
let connection: OpcUaConnection;

beforeEach(async function () {
this.timeout(10000);
mockupServer = new MockupServer();
await mockupServer.initialize();
mockup = new SourceModeDAMockup(mockupServer.nameSpace,
mockup = new SourceModeMockup(mockupServer.nameSpace,
mockupServer.rootObject, 'Variable');
mockup.srcChannel = true;
await mockupServer.start();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import {DataType, Namespace, StatusCodes, UAObject, Variant} from 'node-opcua';
import {SourceMode} from '@p2olab/polaris-interface';

export function getSourceModeDAMockupReferenceJSON(
export function getSourceModeMockupReferenceJSON(
namespace: number,
objectBrowseName: string): object {

Expand Down Expand Up @@ -69,7 +69,7 @@ export function getSourceModeDAMockupReferenceJSON(
});
}

export class SourceModeDAMockup {
export class SourceModeMockup {
srcMode: SourceMode = SourceMode.Intern;
public srcChannel = false;
protected srcManAut = false;
Expand Down Expand Up @@ -195,8 +195,8 @@ export class SourceModeDAMockup {
}


public getSourceModeDAInstanceMockupJSON(): object {
return getSourceModeDAMockupReferenceJSON(
public getSourceModeInstanceMockupJSON(): object {
return getSourceModeMockupReferenceJSON(
this.mockupNode.namespaceIndex,
this.mockupNode.browseName.name as string);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,6 @@ class SourceModeController{
}

SourceModeRuntime <-- SourceModeController
SourceModeDASpec --> SourceModeController : <<uses>>
SourceModeDASpec --> SourceModeDAMockup : <<uses>>
SourceModeSpec --> SourceModeController : <<uses>>
SourceModeSpec --> SourceModeMockup : <<uses>>
@enduml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {DataAssemblyOptions, SourceMode} from '@p2olab/polaris-interface';
import * as baseDataAssemblyOptions from './SourceModeController.spec.json';
import {BinManInt} from '../../operationElement';
import {MockupServer} from '../../../../_utils';
import {SourceModeDAMockup} from './SourceModeDA.mockup';
import {SourceModeMockup} from './SourceMode.mockup';
import {SourceModeController} from './SourceModeController';

chai.use(chaiAsPromised);
Expand Down Expand Up @@ -73,7 +73,7 @@ describe('SourceModeController', () => {
organizedBy: mockupServer.rootObject,
browseName: 'Variable',
});
new SourceModeDAMockup(mockupServer.nameSpace, mockupNode,'Variable');
new SourceModeMockup(mockupServer.nameSpace, mockupNode,'Variable');
await mockupServer.start();
connection = new OpcUaConnection();
connection.initialize({endpoint: mockupServer.endpoint});
Expand Down Expand Up @@ -108,7 +108,7 @@ describe('SourceModeController', () => {
describe('dynamic functions, manual', async () => {
let mockupServer: MockupServer;
let connection: OpcUaConnection;
let mockup: SourceModeDAMockup;
let mockup: SourceModeMockup;
let sourceMode: SourceModeController;
let dataAssemblyController: any;

Expand All @@ -119,7 +119,7 @@ describe('SourceModeController', () => {
organizedBy: mockupServer.rootObject,
browseName: 'Variable',
});
mockup = new SourceModeDAMockup(
mockup = new SourceModeMockup(
mockupServer.nameSpace,
mockupNode,
'Variable');
Expand Down Expand Up @@ -185,7 +185,7 @@ describe('SourceModeController', () => {
organizedBy: mockupServer.rootObject,
browseName: 'Variable',
});
new SourceModeDAMockup(mockupServer.nameSpace, mockupNode, 'Variable');
new SourceModeMockup(mockupServer.nameSpace, mockupNode, 'Variable');
await mockupServer.start();

connection = new OpcUaConnection();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {DataType, Namespace, StatusCodes, UAObject, Variant} from 'node-opcua';
import {getOpModeMockupReferenceJSON, OpModeMockup} from '../../_extensions/opMode/OpMode.mockup';
import {WQCDAMockup} from '../../_extensions/wqcDA/WQCDA.mockup';
import {OSLevelMockup} from '../../_extensions/osLevel/OSLevel.mockup';
import {getSourceModeDAMockupReferenceJSON, SourceModeDAMockup} from '../../_extensions/sourceModeDA/SourceModeDA.mockup';
import {getSourceModeMockupReferenceJSON, SourceModeMockup} from '../../_extensions/sourceMode/SourceMode.mockup';
import {getActiveElementMockupReferenceJSON} from '../ActiveElement.mockup';


Expand All @@ -37,7 +37,7 @@ export function getPIDCtrlMockupReferenceJSON(

return ({
...getActiveElementMockupReferenceJSON(namespace,objectBrowseName),
...getSourceModeDAMockupReferenceJSON(namespace,objectBrowseName),
...getSourceModeMockupReferenceJSON(namespace,objectBrowseName),
...getOpModeMockupReferenceJSON(namespace, objectBrowseName),
PV: {
namespaceIndex: `${namespace}`,
Expand Down Expand Up @@ -169,7 +169,7 @@ export class PIDCtrlMockup {
public wqc: WQCDAMockup;
public osLevel: OSLevelMockup;
public opMode: OpModeMockup;
public sourceMode: SourceModeDAMockup;
public sourceMode: SourceModeMockup;
public pv= 0;
public pvSclMin= 0;
public pvSclMax= 0;
Expand Down Expand Up @@ -212,7 +212,7 @@ export class PIDCtrlMockup {
this.osLevel = new OSLevelMockup(namespace, this.mockupNode, this.name);
this.wqc = new WQCDAMockup(namespace, this.mockupNode, this.name);
this.opMode = new OpModeMockup(namespace, this.mockupNode, this.name);
this.sourceMode = new SourceModeDAMockup(namespace, this.mockupNode, this.name);
this.sourceMode = new SourceModeMockup(namespace, this.mockupNode, this.name);

namespace.addVariable({
componentOf: this.mockupNode,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@

import {DataType, Namespace, StatusCodes, UAObject, Variant} from 'node-opcua';
import {
getSourceModeDAMockupReferenceJSON,
SourceModeDAMockup
} from '../../../_extensions/sourceModeDA/SourceModeDA.mockup';
getSourceModeMockupReferenceJSON,
SourceModeMockup
} from '../../../_extensions/sourceMode/SourceMode.mockup';
import {DrvMockup, getDrvMockupReferenceJSON} from '../Drv.mockup';


Expand All @@ -36,7 +36,7 @@ export function getAnaDrvMockupReferenceJSON(
objectBrowseName: string): object {

return ({
...getSourceModeDAMockupReferenceJSON(namespace,objectBrowseName),
...getSourceModeMockupReferenceJSON(namespace,objectBrowseName),
...getDrvMockupReferenceJSON(namespace,objectBrowseName),
RpmSclMax: {
namespaceIndex: `${namespace}`,
Expand Down Expand Up @@ -99,7 +99,7 @@ export function getAnaDrvMockupReferenceJSON(

export class AnaDrvMockup extends DrvMockup{

public sourceMode: SourceModeDAMockup;
public sourceMode: SourceModeMockup;

public rpmSclMin= 0;
public rpmSclMax= 0;
Expand All @@ -116,7 +116,7 @@ export class AnaDrvMockup extends DrvMockup{
constructor(namespace: Namespace, rootNode: UAObject, variableName: string) {
super(namespace, rootNode, variableName);

this.sourceMode= new SourceModeDAMockup(namespace,this.mockupNode,this.name);
this.sourceMode= new SourceModeMockup(namespace,this.mockupNode,this.name);

namespace.addVariable({
componentOf: this.mockupNode,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@

import {DataType, Namespace, StatusCodes, UAObject, Variant} from 'node-opcua';
import {
getSourceModeDAMockupReferenceJSON,
SourceModeDAMockup
} from '../../../_extensions/sourceModeDA/SourceModeDA.mockup';
getSourceModeMockupReferenceJSON,
SourceModeMockup
} from '../../../_extensions/sourceMode/SourceMode.mockup';
import {getVlvMockupReferenceJSON, VlvMockup} from '../Vlv.mockup';


Expand All @@ -37,7 +37,7 @@ export function getAnaVlvMockupReferenceJSON(

return ({
...getVlvMockupReferenceJSON(namespace, objectBrowseName),
...getSourceModeDAMockupReferenceJSON(namespace,objectBrowseName),
...getSourceModeMockupReferenceJSON(namespace,objectBrowseName),
Pos: {
namespaceIndex: `${namespace}`,
nodeId: `${objectBrowseName}.Pos`,
Expand Down Expand Up @@ -109,7 +109,7 @@ export function getAnaVlvMockupReferenceJSON(

export class AnaVlvMockup extends VlvMockup{

public sourceModeMockup: SourceModeDAMockup;
public sourceModeMockup: SourceModeMockup;

public posSclMin = 0;
public posSclMax = 0;
Expand All @@ -129,7 +129,7 @@ export class AnaVlvMockup extends VlvMockup{

super(namespace, rootNode, variableName);

this.sourceModeMockup = new SourceModeDAMockup(namespace, rootNode, variableName);
this.sourceModeMockup = new SourceModeMockup(namespace, rootNode, variableName);

namespace.addVariable({
componentOf: this.mockupNode,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@

import {DataType, Namespace, UAObject, Variant} from 'node-opcua';
import {
getSourceModeDAMockupReferenceJSON,
SourceModeDAMockup
} from '../../../_extensions/sourceModeDA/SourceModeDA.mockup';
getSourceModeMockupReferenceJSON,
SourceModeMockup
} from '../../../_extensions/sourceMode/SourceMode.mockup';
import {getWQCDAMockupReferenceJSON, WQCDAMockup} from '../../../_extensions/wqcDA/WQCDA.mockup';
import {AnaManMockup, getAnaManMockupReferenceJSON} from './AnaMan.mockup';

Expand All @@ -39,7 +39,7 @@ export function getAnaManIntMockupReferenceJSON(
return ({
...getAnaManMockupReferenceJSON(namespace,objectBrowseName),
...getWQCDAMockupReferenceJSON(namespace,objectBrowseName),
...getSourceModeDAMockupReferenceJSON(namespace,objectBrowseName),
...getSourceModeMockupReferenceJSON(namespace,objectBrowseName),
VInt: {
namespaceIndex: `${namespace}`,
nodeId: `${objectBrowseName}.VInt`,
Expand All @@ -53,13 +53,13 @@ export class AnaManIntMockup extends AnaManMockup{

protected vInt = 0;
public readonly wqc: WQCDAMockup;
public readonly sourceMode: SourceModeDAMockup;
public readonly sourceMode: SourceModeMockup;

constructor(namespace: Namespace, rootNode: UAObject, variableName: string) {
super(namespace, rootNode, variableName);

this.wqc = new WQCDAMockup(namespace, this.mockupNode, this.name);
this.sourceMode = new SourceModeDAMockup(namespace, this.mockupNode, this.name);
this.sourceMode = new SourceModeMockup(namespace, this.mockupNode, this.name);

namespace.addVariable({
componentOf: this.mockupNode,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import {DataType, Namespace, UAObject, Variant} from 'node-opcua';

import {
getSourceModeDAMockupReferenceJSON,
SourceModeDAMockup
} from '../../../_extensions/sourceModeDA/SourceModeDA.mockup';
getSourceModeMockupReferenceJSON,
SourceModeMockup
} from '../../../_extensions/sourceMode/SourceMode.mockup';
import {BinManMockup, getBinManMockupReferenceJSON} from './BinMan.mockup';
import {getWQCDAMockupReferenceJSON, WQCDAMockup} from '../../../_extensions/wqcDA/WQCDA.mockup';

Expand All @@ -38,7 +38,7 @@ export function getBinManIntMockupReferenceJSON(
return ({
...getBinManMockupReferenceJSON(namespace, objectBrowseName),
...getWQCDAMockupReferenceJSON(namespace, objectBrowseName),
...getSourceModeDAMockupReferenceJSON(namespace,objectBrowseName),
...getSourceModeMockupReferenceJSON(namespace,objectBrowseName),
VInt: {
namespaceIndex: `${namespace}`,
nodeId: `${objectBrowseName}.VInt`,
Expand All @@ -51,13 +51,13 @@ export function getBinManIntMockupReferenceJSON(
export class BinManIntMockup extends BinManMockup {
protected vInt = false;
public readonly wqc: WQCDAMockup;
public readonly sourceMode: SourceModeDAMockup;
public readonly sourceMode: SourceModeMockup;

constructor(namespace: Namespace, rootNode: UAObject, variableName: string) {
super(namespace, rootNode, variableName);

this.wqc = new WQCDAMockup(namespace, this.mockupNode, this.name);
this.sourceMode = new SourceModeDAMockup(namespace, this.mockupNode, this.name);
this.sourceMode = new SourceModeMockup(namespace, this.mockupNode, this.name);

namespace.addVariable({
componentOf: this.mockupNode,
Expand Down
Loading