linting

src/modularPlantManager/ModularPlantManager.ts

@@ -23,7 +23,7 @@
  * SOFTWARE.
  */
 
-import {BackendNotification, PEAInterface, PEAModel, PEAOptions, POLServiceInterface, POLServiceOptions, RecipeOptions, ServerSettingsOptions, ServiceCommand, VariableChange,} from '@p2olab/polaris-interface';
+import {BackendNotification, PEAInterface, PEAModel, PEAOptions, POLServiceInterface, POLServiceOptions, RecipeOptions, ServiceCommand, VariableChange,} from '@p2olab/polaris-interface';
 import {Backbone, PEAPool, PEAPoolVendor,} from '@p2olab/pimad-core';
 import {catManager, ServiceLogEntry} from '../logging';
 import {ParameterChange, PEAController, Service} from './pea';

src/modularPlantManager/_utils/mockupServer.ts

@@ -129,7 +129,7 @@ export class MockupServer {
 
 		const namespace: Namespace = addressSpace.getOwnNamespace();
 
-		this.namespace = addressSpace.registerNamespace('urn:P2OLab:NodeOPCUA-Server');;
+		this.namespace = addressSpace.registerNamespace('urn:P2OLab:NodeOPCUA-Server');
 		// declare a new object
 		const myMockup = namespace.addObject({
 			organizedBy: addressSpace.rootFolder.objects,

src/modularPlantManager/condition/index.ts

@@ -1,6 +1,5 @@
 export * from './Condition';
 export * from './ConditionFactory';
-
 export * from './custom';
 export * from './logical';
 export * from './peaCondition';

src/modularPlantManager/pea/PiMAdParser/PiMAdParser.ts

@@ -94,9 +94,9 @@ export class PiMAdParser {
     }
 
     /**
-     * @param dataAssemblyModels {DataAssemblyModel[]}
      * @return {DataAssemblyOptions[]}
      * @private
+     * @param procedureModels
      */
     private static createProcedureOptionsArray(procedureModels: ProcedureModel[]): ProcedureOptions[] {
         const procedureOptionsArray: ProcedureOptions[] = [];

src/modularPlantManager/pea/StateMachine/MtpStateMachine.ts

@@ -287,65 +287,65 @@ export class MtpStateMachine {
 
   public readonly defaultOptions: UserDefinedServiceConfiguration = {
     guards: {
-      startingEnabled: () => true,
-      restartingEnabled: () => true,
-      executeEnabled: () => true,
-      completingEnabled: () => true,
-      pausingEnabled: () => true,
-      holdingEnabled: () => false,
-      unholdingEnabled: () => true,
+      startingEnabled: (): boolean => true,
+      restartingEnabled: (): boolean => true,
+      executeEnabled: (): boolean => true,
+      completingEnabled: (): boolean => true,
+      pausingEnabled: (): boolean => true,
+      holdingEnabled: (): boolean => false,
+      unholdingEnabled: (): boolean => true,
     },
     actions: {
-      onIdle: () => { return; },
-      onStarting: () => this.goToNextState(),
-      onExecute: () => { return; },
-      onCompleting: () => this.goToNextState(),
-      onCompleted: () => { return; },
-      onResetting: () => this.goToNextState(),
-      onPausing: () => this.goToNextState(),
-      onPaused: () => { return; },
-      onResuming: () => this.goToNextState(),
-      onStopping: () => this.goToNextState(),
-      onStopped: () => { return; },
-      onAborting: () => this.goToNextState(),
-      onAborted: () => { return; },
+      onIdle: (): void => { return; },
+      onStarting: (): void  => this.goToNextState(),
+      onExecute: (): void  => { return; },
+      onCompleting: (): void  => this.goToNextState(),
+      onCompleted: (): void  => { return; },
+      onResetting: (): void  => this.goToNextState(),
+      onPausing: (): void  => this.goToNextState(),
+      onPaused: (): void  => { return; },
+      onResuming: (): void  => this.goToNextState(),
+      onStopping: (): void  => this.goToNextState(),
+      onStopped: (): void  => { return; },
+      onAborting: (): void  => this.goToNextState(),
+      onAborted: (): void  => { return; },
     },
   };
 
   private staticOptions: StaticServiceConfiguration = {
-    guards: { startingEnabledStatic: () => true},
+    guards: { startingEnabledStatic: (): boolean => true},
     actions: {
-      onStartingStatic: () => {this.updateProcedureCur();},
-      onResettingStatic: () => {return;}
+      onStartingStatic: (): void  => {this.updateProcedureCur();},
+      onResettingStatic: (): void  => {return;}
     }
   }
 
-  public reconfigure(updatedGuards: Partial<UserDefinedGuard>, updatedActions: Partial<UserDefinedActions>) {
+  public reconfigure(updatedGuards: Partial<UserDefinedGuard>, updatedActions: Partial<UserDefinedActions>): void {
     const guards: UserDefinedGuard =
       { ...this.staticOptions.guards,...this.defaultOptions.guards, ...updatedGuards} as UserDefinedGuard;
     const actions: UserDefinedActions =
       { ...this.staticOptions.actions,...this.defaultOptions.actions, ...updatedActions} as UserDefinedActions;
     this.stateMachine = this.stateMachine.withConfig({guards, actions});
   }
 
-  public setProcedureReq(procedureReq: number){
+  public setProcedureReq(procedureReq: number): void{
     this.varProcedureReq = procedureReq;
   }
 
-  private updateProcedureCur(){
+  private updateProcedureCur(): void{
     this.varProcedureCur = this.getProcedureReq();
   }
-  private resetProcedureCur(){
+  private resetProcedureCur(): void{
     this.varProcedureCur = 0;
   }
 
-  public getProcedureReq() {return this.varProcedureReq;}
-  public getProcedureCur() {return this.varProcedureCur;}
+  public getProcedureReq(): number {return this.varProcedureReq;}
+  public getProcedureCur(): number {return this.varProcedureCur;}
 
 
   /* Start ServiceStateMachine
   */
-  public start() {
+  public start(): void {
     this.stateMachineService = interpret(this.stateMachine);
     this.stateMachineService.onTransition(() => console.log(`[STATEMACHINE] FSM (${this.name}): ${this.getState()}`))
       .start();
@@ -372,7 +372,7 @@ export class MtpStateMachine {
     else throw Error('StateMachine not initialized.');
   }
 
-  public goToNextState() {
+  public goToNextState(): void {
     if(this.stateMachineService) this.stateMachineService.send('SC');
   }
 

src/modularPlantManager/pea/dataAssembly/_extensions/feedbackMonitoringDA/FeedbackMonitoring.ts

@@ -24,8 +24,7 @@
  */
 
 import {OpcUaDataItem} from '../../../connection';
-import {BaseDataAssemblyRuntime, DataAssemblyController} from '../../DataAssemblyController';
-import {Constructor} from '../_helper';
+import {BaseDataAssemblyRuntime} from '../../DataAssemblyController';
 
 export interface FeedbackMonitoringRuntime extends BaseDataAssemblyRuntime {
 	MonEn: OpcUaDataItem<boolean>;

src/modularPlantManager/pea/dataAssembly/_extensions/interlockDA/Interlock.ts

@@ -24,8 +24,7 @@
  */
 
 import {OpcUaDataItem} from '../../../connection';
-import {BaseDataAssemblyRuntime, DataAssemblyController} from '../../DataAssemblyController';
-import {Constructor} from '../_helper';
+import {BaseDataAssemblyRuntime} from '../../DataAssemblyController';
 
 export type InterlockRuntime = BaseDataAssemblyRuntime & {
 	PermEn: OpcUaDataItem<boolean>;

src/modularPlantManager/pea/dataAssembly/_extensions/limitMonitoringDA/LimitMonitoring.ts

@@ -24,8 +24,7 @@
  */
 
 import {OpcUaDataItem} from '../../../connection';
-import {Constructor} from '../_helper';
-import {BaseDataAssemblyRuntime, DataAssemblyController} from '../../DataAssemblyController';
+import {BaseDataAssemblyRuntime} from '../../DataAssemblyController';
 
 export type LimitMonitoringRuntime = BaseDataAssemblyRuntime & {
 	VAHEn: OpcUaDataItem<boolean>;

src/modularPlantManager/pea/dataAssembly/_extensions/osLevelDA/OSLevel.ts

@@ -24,8 +24,7 @@
  */
 
 import {OpcUaDataItem} from '../../../connection';
-import {Constructor} from '../_helper';
-import {BaseDataAssemblyRuntime, DataAssemblyController} from '../../DataAssemblyController';
+import {BaseDataAssemblyRuntime} from '../../DataAssemblyController';
 
 export interface OSLevelRuntime extends BaseDataAssemblyRuntime {
 	OSLevel: OpcUaDataItem<number>;

src/modularPlantManager/pea/dataAssembly/_extensions/scaleSettingsDA/ScaleSettings.ts

@@ -23,11 +23,8 @@
  * SOFTWARE.
  */
 
-import {ParameterInterface} from '@p2olab/polaris-interface';
 import {OpcUaDataItem} from '../../../connection';
-import {Constructor} from '../_helper';
-import {BaseDataAssemblyRuntime, DataAssemblyController} from '../../DataAssemblyController';
-import {AnaView} from '../../indicatorElement';
+import {BaseDataAssemblyRuntime} from '../../DataAssemblyController';
 
 export interface ScaleSettingsRuntime extends BaseDataAssemblyRuntime {
 	VSclMin: OpcUaDataItem<number>;
@@ -42,7 +39,7 @@ export class ScaleSettings {
 			this.initialize();
 		}
 
-		private initialize(){
+		private initialize(): void{
 			this.dAController.communication.VSclMax = this.dAController.createDataItem('VSclMax', 'read');
 			this.dAController.communication.VSclMin = this.dAController.createDataItem('VSclMin', 'read');
 		}

src/modularPlantManager/pea/dataAssembly/_extensions/serviceSourceModeDA/ServiceSourceModeController.ts

@@ -25,11 +25,8 @@
 
 import {ServiceSourceMode} from '@p2olab/polaris-interface';
 import {OpcUaDataItem} from '../../../connection';
-import {BaseDataAssemblyRuntime, DataAssemblyController} from '../../DataAssemblyController';
-import {Constructor} from '../_helper';
+import {BaseDataAssemblyRuntime} from '../../DataAssemblyController';
 import {catDataAssembly} from '../../../../../logging';
-import {AnaServParamMockup} from '../../operationElement/servParam/anaServParam/AnaServParam.mockup';
-import {AnaServParam} from '../../operationElement';
 
 export interface ServiceSourceModeRuntime extends BaseDataAssemblyRuntime {
 	SrcChannel: OpcUaDataItem<boolean>;

src/modularPlantManager/pea/dataAssembly/_extensions/valueLimitationDA/ValueLimitation.ts

@@ -23,10 +23,8 @@
  * SOFTWARE.
  */
 
-import {ParameterInterface} from '@p2olab/polaris-interface';
 import {OpcUaDataItem} from '../../../connection';
-import {BaseDataAssemblyRuntime, DataAssemblyController} from '../../DataAssemblyController';
-import {Constructor} from '../_helper';
+import {BaseDataAssemblyRuntime} from '../../DataAssemblyController';
 
 export type ValueLimitationRuntime = BaseDataAssemblyRuntime & {
 	VMin: OpcUaDataItem<number>;

src/modularPlantManager/pea/dataAssembly/_extensions/wqcDA/WQC.ts

@@ -24,8 +24,7 @@
  */
 
 import {OpcUaDataItem} from '../../../connection';
-import {BaseDataAssemblyRuntime, Constructor} from '../../index';
-import {DataAssemblyController} from '../../DataAssemblyController';
+import {BaseDataAssemblyRuntime} from '../../index';
 
 export interface WQCRuntime extends BaseDataAssemblyRuntime {
 	WQC: OpcUaDataItem<number>;

src/modularPlantManager/pea/dataAssembly/activeElement/vlv/binVlv/BinVlv.ts

@@ -1,4 +1,3 @@
-/* tslint:disable:max-classes-per-file */
 /*
 * MIT License
 *

src/modularPlantManager/pea/dataAssembly/diagnosticElement/DiagnosticElement.ts

@@ -25,12 +25,10 @@
 
 import {DataAssemblyOptions} from '@p2olab/polaris-interface';
 import {OpcUaConnection} from '../../connection';
-import {OSLevelRuntime, WQCRuntime} from '../_extensions';
+import {OSLevelRuntime, WQC, WQCRuntime} from '../_extensions';
 import {
 	BaseDataAssemblyRuntime, DataAssemblyController,
 } from '../DataAssemblyController';
-import {OSLevel} from '../_extensions/osLevelDA/OSLevel';
-import {WQC} from '../_extensions/wqcDA/WQC';
 
 export type DiagnosticElementRuntime = BaseDataAssemblyRuntime & WQCRuntime & OSLevelRuntime;
 

src/modularPlantManager/pea/dataAssembly/diagnosticElement/healthStateView/HealthStateView.spec.ts

@@ -31,7 +31,6 @@ import * as chaiAsPromised from 'chai-as-promised';
 import {DataAssemblyOptions} from '@p2olab/polaris-interface';
 import * as baseDataAssemblyOptions from './HealthStateView.spec.json';
 import {MockupServer} from '../../../../_utils';
-import {Namespace, UAObject} from 'node-opcua';
 import {HealthStateViewMockup} from './HealthStateView.mockup';
 
 

src/modularPlantManager/pea/dataAssembly/diagnosticElement/healthStateView/HealthStateView.ts

@@ -1,4 +1,3 @@
-/* tslint:disable:max-classes-per-file */
 /*
  * MIT License
  *

src/modularPlantManager/pea/dataAssembly/diagnosticElement/index.ts

@@ -1,4 +1,3 @@
 export * from './DiagnosticElement';
 export * from './healthStateView/HealthStateView';
-
 export * from './lockView';

src/modularPlantManager/pea/dataAssembly/diagnosticElement/lockView/LockView4.ts

@@ -1,4 +1,3 @@
-/* tslint:disable:max-classes-per-file */
 /*
  * MIT License
  *

src/modularPlantManager/pea/dataAssembly/diagnosticElement/lockView/LockView8.ts

@@ -1,4 +1,3 @@
-/* tslint:disable:max-classes-per-file */
 /*
  * MIT License
  *

src/modularPlantManager/pea/dataAssembly/indicatorElement/AnaView/AnaMon.ts

@@ -25,10 +25,14 @@
  */
 
 import {AnaView, AnaViewRuntime} from './AnaView';
-import {OpcUaConnection, OpcUaDataItem} from '../../../connection';
+import {OpcUaConnection} from '../../../connection';
 import {DataAssemblyOptions} from '@p2olab/polaris-interface';
-import {LimitMonitoring, LimitMonitoringRuntime} from '../../_extensions/limitMonitoringDA/LimitMonitoring';
-import {OSLevel, OSLevelRuntime} from '../../_extensions/osLevelDA/OSLevel';
+import {
+    LimitMonitoring,
+    LimitMonitoringRuntime,
+    OSLevel,
+    OSLevelRuntime
+} from '../../_extensions';
 
 export type AnaMonRuntime = AnaViewRuntime & LimitMonitoringRuntime & OSLevelRuntime
 

src/modularPlantManager/pea/dataAssembly/indicatorElement/AnaView/AnaView.ts

@@ -24,12 +24,12 @@
  * SOFTWARE.
  */
 
-import {DataAssemblyOptions, ParameterInterface} from '@p2olab/polaris-interface';
+import {DataAssemblyOptions} from '@p2olab/polaris-interface';
 import {OpcUaConnection, OpcUaDataItem} from '../../../connection';
 import {ScaleSettingsRuntime, UnitDataAssemblyRuntime} from '../../_extensions';
 import {IndicatorElement, IndicatorElementRuntime} from '../IndicatorElement';
-import {ScaleSettings} from '../../_extensions/scaleSettingsDA/ScaleSettings';
-import {UnitSettings} from '../../_extensions/unitDA/UnitSettings';
+import {ScaleSettings, UnitSettings} from '../../_extensions';
+
 export type AnaViewRuntime = IndicatorElementRuntime & UnitDataAssemblyRuntime & ScaleSettingsRuntime & {
 	V: OpcUaDataItem<number>;
 };

src/modularPlantManager/pea/dataAssembly/indicatorElement/BinView/BinView.ts

@@ -1,4 +1,3 @@
-/* tslint:disable:max-classes-per-file */
 /*
  * MIT License
  *

src/modularPlantManager/pea/dataAssembly/indicatorElement/DIntView/DIntView.ts

@@ -24,12 +24,11 @@
  * SOFTWARE.
  */
 
-import {DataAssemblyOptions, ParameterInterface} from '@p2olab/polaris-interface';
+import {DataAssemblyOptions} from '@p2olab/polaris-interface';
 import {OpcUaConnection} from '../../../connection';
 import {AnaViewRuntime} from '../AnaView/AnaView';
 import {IndicatorElement} from '../IndicatorElement';
-import {UnitSettings} from '../../_extensions/unitDA/UnitSettings';
-import {ScaleSettings} from '../../_extensions/scaleSettingsDA/ScaleSettings';
+import {ScaleSettings, UnitSettings} from '../../_extensions';
 
 
 export class DIntView extends IndicatorElement {

src/modularPlantManager/pea/dataAssembly/indicatorElement/IndicatorElement.ts

@@ -24,12 +24,12 @@
  */
 
 import {DataAssemblyOptions, ParameterInterface} from '@p2olab/polaris-interface';
-import {OpcUaConnection, OpcUaDataItem} from '../../connection';
+import {OpcUaConnection} from '../../connection';
 import {WQCRuntime} from '../_extensions';
 import {
 	BaseDataAssemblyRuntime, DataAssemblyController
 } from '../DataAssemblyController';
-import {WQC} from '../_extensions/wqcDA/WQC';
+import {WQC} from '../_extensions';
 
 export type IndicatorElementRuntime = BaseDataAssemblyRuntime & WQCRuntime
 

src/modularPlantManager/pea/dataAssembly/indicatorElement/index.ts

@@ -1,5 +1,4 @@
 export * from './IndicatorElement';
-
 export * from './AnaView/AnaMon';
 export * from './AnaView/AnaView';
 export * from './BinView/BinMon';

src/modularPlantManager/pea/dataAssembly/inputElement/InputElement.ts

@@ -25,16 +25,14 @@
 
 import {
 	DataAssemblyOptions,
-	InputElementOptions,
 	ParameterInterface,
 	ParameterOptions
 } from '@p2olab/polaris-interface';
 import {DataItem, OpcUaConnection} from '../../connection';
 import {PEAController} from '../../PEAController';
-import {WQCRuntime} from '../_extensions';
+import {WQC, WQCRuntime} from '../_extensions';
 import {BaseDataAssemblyRuntime, DataAssemblyController} from '../DataAssemblyController';
 import {catDataAssembly} from '../../../../logging';
-import {WQC} from '../_extensions/wqcDA/WQC';
 import {Parameter} from '../../../recipe';
 
 export type InputElementRuntime = WQCRuntime & BaseDataAssemblyRuntime ;

src/modularPlantManager/pea/dataAssembly/operationElement/OperationElement.ts

@@ -25,12 +25,12 @@
 
 import {DataAssemblyOptions, ParameterInterface, ParameterOptions} from '@p2olab/polaris-interface';
 import {Parameter} from '../../../recipe';
-import {DataItem, OpcUaConnection, OpcUaDataItem} from '../../connection';
+import {DataItem, OpcUaConnection} from '../../connection';
 import {OSLevelRuntime} from '../_extensions';
 import {BaseDataAssemblyRuntime, DataAssemblyController} from '../DataAssemblyController';
 import {PEAController} from '../../PEAController';
 import {catDataAssembly} from '../../../../logging';
-import {OSLevel} from '../_extensions/osLevelDA/OSLevel';
+import {OSLevel} from '../_extensions';
 
 export type OperationElementRuntime = BaseDataAssemblyRuntime & OSLevelRuntime
 

src/modularPlantManager/pea/dataAssembly/operationElement/index.ts

@@ -1,4 +1,3 @@
 export * from './man';
 export * from './servParam';
-
 export * from './OperationElement';