Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computer vision; viewvideo.c; 'socket' shadows global declaration #2141

Closed
lethargi opened this issue Oct 28, 2017 · 3 comments
Closed

Computer vision; viewvideo.c; 'socket' shadows global declaration #2141

lethargi opened this issue Oct 28, 2017 · 3 comments

Comments

@lethargi
Copy link

Compiling in ap with the computer_vision module throws the warning

modules/computer_vision/viewvideo.c:113:61: warning: declaration of 'socket' shadows a global declaration [-Wshadow]

@lethargi lethargi changed the title Computer vision; viewvideo.c; 'socket' shadows global declaration Computer vision; viewvideo.c; 'socket' shadows global declaration label:computer_vision Oct 28, 2017
@lethargi lethargi changed the title Computer vision; viewvideo.c; 'socket' shadows global declaration label:computer_vision Computer vision; viewvideo.c; 'socket' shadows global declaration Oct 28, 2017
@gautierhattenberger
Copy link
Member

this should be fairly easy to fix by changing the local variable name

@lethargi
Copy link
Author

lethargi commented Nov 1, 2017

I know. wasnt sure if I should change it as it may have been intended. Also I cannot make pull request. any guides which tell me what needs doing for me to fix this and make a pull request?

@dewagter
Copy link
Member

dewagter commented Nov 1, 2017

  • checkout a clean master
  • give it new name: git checkout -b newbranchname
  • make changes and commit
  • push to your github: git push yourremote newbranchname
  • browse to github.com and click pull request

biancabndris pushed a commit to biancabndris/paparazzi that referenced this issue Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants