Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that ensures the committing happens correctly inside Headers Stage #418

Closed
gakonst opened this issue Dec 13, 2022 · 1 comment · Fixed by #843
Closed

Add test that ensures the committing happens correctly inside Headers Stage #418

gakonst opened this issue Dec 13, 2022 · 1 comment · Fixed by #843
Labels
A-staged-sync Related to staged sync (pipelines and stages) C-test A change that impacts how or what we test

Comments

@gakonst
Copy link
Member

gakonst commented Dec 13, 2022

We should have a test that blocks the stream per-batch, letting us check that the commit actually happened while the stage is running. Currently we're only testing that the entire stream has been committed.

Originally posted by @gakonst in #406 (comment)

@onbjerg onbjerg added A-staged-sync Related to staged sync (pipelines and stages) C-test A change that impacts how or what we test labels Dec 13, 2022
@MegaRedHand
Copy link
Contributor

I think this issue can be closed. After #609, the headers stage doesn't commit directly, and returns control to the pipeline after a number of headers. Although we are missing some test that tries to execute the stage in multiple steps (see BodyStage's sync_from_previous_progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-staged-sync Related to staged sync (pipelines and stages) C-test A change that impacts how or what we test
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants