test: add test for header stage two step download #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdaclass-user
requested review from
onbjerg,
rkrasiuk and
gakonst
as code owners
onbjerg
added
C-test
|
Hey! When opening up a PR that closes an issue, you can use special words to link the PR and the issue, which auto-closes the issue when it is merged. For example: We would also appreciate adding a small comment on the issue when starting work on it so we can assign the issues: it helps communicate what is up for grabs! Unfortunately, GitHub does not allow us to assign without the comment first. It helps keep the issue tracker clean 😄 Thanks for taking this on! |
|
Sorry for that! Will do! |
gakonst
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked: #418
This PR adds a test for
HeaderStagewhere more thancommit_thresholdheaders are downloaded, requiring a second call toHeaderStage::execute.