fix(sync): commit headers upon threshold #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 74.13% 74.30% +0.16%
==========================================
Files 236 234 -2
Lines 22231 22253 +22
==========================================
+ Hits 16481 16535 +54
+ Misses 5750 5718 -32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gakonst
approved these changes
Dec 13, 2022
| @@ -97,6 +101,7 @@ impl<DB: Database, D: HeaderDownloader, C: Consensus, H: HeadersClient> Stage<DB | |||
| self.validate_header_response(&res)?; | |||
| let write_progress = | |||
| self.write_headers::<DB>(db, res).await?.unwrap_or_default(); | |||
| db.commit()?; | |||
There was a problem hiding this comment.
We could write a test that blocks the stream per-batch, letting us check that the commit actually happened while the stage is running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit the transaction with header-related entries upon reaching the
commit_threshold. The control flow is not returned to the pipeline (which would be responsible for committing under ordinary circumstances), because the Headers stage needs to preserve context while downloading from the tip.The control flow is returned to the pipeline for committing new
HeaderTDentries