This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use same fmt and clippy configs as in Polkadot
#3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
ggwpez
commented
Aug 14, 2023
| /// Proof: System Account (max_values: None, max_size: Some(128), added: 2603, mode: MaxEncodedLen) | ||
| /// The range of component `b` is `[1, 19]`. | ||
| /// Proof: CollatorSelection Invulnerables (max_values: Some(1), max_size: Some(641), added: | ||
| /// 1136, mode: MaxEncodedLen) Storage: CollatorSelection Candidates (r:1 w:1) |
There was a problem hiding this comment.
This is the only weight file where the comments are too long.
We could either add #[rustfmt::skip] to the weight template, or exclude it in the rustfmt.toml file. Former is probably better, since the file paths will change in the monorepo.
Since it is only one file, i will leave it like this after the monorepo.
Looks like paritytech/polkadot#7611 did not correctly update the lockfile. Maybe a different Rust Version?! Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
B0-silent
ordian
approved these changes
Aug 14, 2023
bkchr
approved these changes
Aug 14, 2023
|
bot merge |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as paritytech/polkadot#7611 and part of #2970 (preparation for monorepo)
Changes:
rustfmt.tomland Clippy config from Substrate/Polkadot master.comment_width = 100andwrap_comments = true.