Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use same fmt and clippy configs as in Substrate #7611

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Use same fmt and clippy configs as in Substrate #7611

merged 8 commits into from
Aug 14, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 14, 2023 •
edited
Loading

Part of paritytech/cumulus#2970 (preparation for monorepo)

Changes:

  • Copy rustfmt.toml and Clippy config from Substrate master.
  • Format code with new config. All the code changes should be due to comment_width = 100 and wrap_comments = true.
  • Add Clippy version logging to the CI.
  • TODO: Fix clippy warnings.

@ggwpez
Use same rustfmt.toml as Substrate
ad315c4 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
format format file
89b49b1 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Format with new config
7986fb8 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add Substrate Clippy config
6661fb7 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Print Clippy version in CI
34d0309 
Otherwise its difficult to reproduce locally.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 14, 2023
@ggwpez
Make fmt happy
e87735c 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review August 14, 2023 12:34
@ggwpez ggwpez requested review from chevdor and a team as code owners August 14, 2023 12:34
@ggwpez ggwpez added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 14, 2023
@ggwpez ggwpez self-assigned this Aug 14, 2023
@paritytech-ci paritytech-ci requested review from a team August 14, 2023 12:34
@paritytech-ci paritytech-ci requested a review from a team August 14, 2023 12:53
chevdor
chevdor approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

ggwpez and others added 2 commits August 14, 2023 15:03
@ggwpez @tdimitrov
Update node/core/pvf/src/error.rs
b4c25cb 
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
@ggwpez @tdimitrov
Update node/core/pvf/src/error.rs
2a39367 
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Aug 14, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 247e4a7 into master Aug 14, 2023
7 checks passed
@paritytech-processbot paritytech-processbot bot deleted the oty-config-parity branch August 14, 2023 14:29
This was referenced Aug 14, 2023
Closed
Merged
ggwpez added a commit to paritytech/cumulus that referenced this pull request Aug 14, 2023
@ggwpez
Update Cargo.lock
8106085 
Looks like paritytech/polkadot#7611 did not
correctly update the lockfile. Maybe a different Rust Version?!

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this pull request Aug 14, 2023
Merged
paritytech-processbot bot pushed a commit to paritytech/cumulus that referenced this pull request Aug 14, 2023
@ggwpez
Update Cargo.lock (#3005)
1b890d8 
Looks like paritytech/polkadot#7611 did not
correctly update the lockfile. Maybe a different Rust Version?!

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
paritytech-processbot bot pushed a commit to paritytech/cumulus that referenced this pull request Aug 14, 2023
@ggwpez
Use same fmt and clippy configs as in Polkadot (#3004)
234b821 
* Copy rustfmt.toml from Polkadot master

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Format with new config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add Polkadot clippy config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update Cargo.lock

Looks like paritytech/polkadot#7611 did not
correctly update the lockfile. Maybe a different Rust Version?!

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkontur bkontur mentioned this pull request Aug 25, 2023
Closed
s0me0ne-unkn0wn pushed a commit that referenced this pull request Aug 15, 2023
@ggwpez @tdimitrov @s0me0ne-unkn0wn
Use same fmt and clippy configs as in Substrate (#7611)
6f9fe26 
* Use same rustfmt.toml as Substrate

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* format format file

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Format with new config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add Substrate Clippy config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Print Clippy version in CI

Otherwise its difficult to reproduce locally.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Make fmt happy

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update node/core/pvf/src/error.rs

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

* Update node/core/pvf/src/error.rs

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tdimitrov tdimitrov tdimitrov approved these changes

@chevdor chevdor chevdor approved these changes

@ordian ordian ordian approved these changes

@bkchr bkchr bkchr approved these changes

@alvicsam alvicsam alvicsam approved these changes

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ggwpez @tdimitrov @chevdor @ordian @bkchr @alvicsam