This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for #10403: Remove Default for AccountId #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A3-inprogress
B0-silent
gavofyork
commented
Dec 11, 2021
shawntabrizi
approved these changes
Dec 14, 2021
Comment on lines
+228
to
+232
|
|
||
| let balances = vec![(1, 100), (2, 100), (3, 100), (4, 100), (5, 100)]; | ||
| let keys = balances | ||
| .iter() | ||
| .map(|i| (*i, *i, MockSessionKeys { aura: UintAuthorityId(*i) })) | ||
| .map(|&(i, _)| (i, i, MockSessionKeys { aura: UintAuthorityId(i) })) |
There was a problem hiding this comment.
this is a logic change. Before the keys only included [1, 2], and now has 1 through 5.
Is there a reason?
There was a problem hiding this comment.
Yes - other keys were used in tests as validators, but they won't show up in the validator list unless they have a session key defined (this is the change).
They always should have had a session key defined, but we got away without it previously because we used a very lazy and not very correct .unwrap_or_default() when retrieving the validators' session keys.
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#10403