Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion #10403: Remove Default for AccountId #4500

Merged
merged 22 commits into from
Dec 14, 2021
Merged

Companion #10403: Remove Default for AccountId #4500

merged 22 commits into from
Dec 14, 2021

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Dec 9, 2021 •
edited by shawntabrizi
Loading

@gavofyork gavofyork added the A3-in_progress Pull request is in progress. No review needed at this stage. label Dec 9, 2021
@drahnr
Copy link
Contributor

drahnr commented Dec 10, 2021

Some of these changes are overlapping with #4484 which will remove the Default implementations and introduce a helper crate to isolate the fn dummy_* helpers.

@gavofyork gavofyork mentioned this pull request Dec 10, 2021
Merged
gavofyork
gavofyork commented Dec 11, 2021
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
@gavofyork gavofyork added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Dec 12, 2021
@gavofyork gavofyork added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Dec 12, 2021
@nuke-web3 nuke-web3 mentioned this pull request Dec 13, 2021
Open
shawntabrizi
shawntabrizi approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gavofyork gavofyork merged commit 468a75e into master Dec 14, 2021
@gavofyork gavofyork deleted the gav-no-default-accountid branch December 14, 2021 07:17
This was referenced Dec 14, 2021
Closed
Closed
@drahnr drahnr mentioned this pull request Jan 13, 2022
Merged
@librelois librelois mentioned this pull request Feb 7, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian left review comments

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@acatangiu acatangiu Awaiting requested review from acatangiu

@adoerr adoerr Awaiting requested review from adoerr

@antonio-dropulic antonio-dropulic Awaiting requested review from antonio-dropulic

@svyatonik svyatonik Awaiting requested review from svyatonik

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavofyork @drahnr @shawntabrizi @ordian