Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Don't allow bids for a ParaId where there is an overlapping lease period #3361

Merged
18 commits merged into from
Jun 25, 2021

Conversation

shawntabrizi
Copy link
Member

This PR introduces a check when calling handle_bid which checks that an auction bid is not for a parachain which already has a lease period which overlaps with that bid.

This ensures that parachain teams do not steal potential lease periods from other teams, and that crowdloans will never be able to re-enter other auctions after winning (since the crowdloan has specific lease periods it bids for).

Co-Authored-By: parity-processbot <>
Co-Authored-By: parity-processbot <>
Co-Authored-By: parity-processbot <>
Co-Authored-By: parity-processbot <>
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jun 24, 2021
@emostov emostov self-requested a review June 24, 2021 16:29
@kianenigma kianenigma self-requested a review June 24, 2021 17:37
@@ -135,6 +135,14 @@ pub trait Leaser {

/// Returns the current lease period.
fn lease_period_index() -> Self::LeasePeriod;

/// Returns true if the parachain already has a lease in any of lease periods in the inclusive
/// range `[first_period, last_period]`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be slightly incorrect: technically our implementation in slots only can check the current lease period and onwards. So if any periods in first_period..=last_period are in the past we will not be able to look at those. Additionally we will always return false if the entire range is in the past (I don't think this is an issue but just wanted to point it out)

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new logic looks good - planning on adding a test just to confirm my understanding

runtime/common/src/slots.rs Outdated Show resolved Hide resolved
runtime/common/src/slots.rs Outdated Show resolved Hide resolved
runtime/common/src/slots.rs Outdated Show resolved Hide resolved
shawntabrizi and others added 5 commits June 24, 2021 21:31
@shawntabrizi
Copy link
Member Author

/benchmark runtime kusama runtime_common::auctions

@parity-benchapp
Copy link

parity-benchapp bot commented Jun 24, 2021

Finished benchmark for branch: shawntabrizi-check-bid

Benchmark: Benchmark Runtime Kusama Pallet

cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_auctions.rs

Results

Pallet: "runtime_common::auctions", Extrinsic: "new_auction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 29.71
µs

Reads = 2
Writes = 2
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 29.71
µs

Reads = 2
Writes = 2
Pallet: "runtime_common::auctions", Extrinsic: "bid", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 155.7
µs

Reads = 8
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 155.7
µs

Reads = 8
Writes = 4
Pallet: "runtime_common::auctions", Extrinsic: "on_initialize", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 32830
µs

Reads = 3688
Writes = 3683
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 32830
µs

Reads = 3688
Writes = 3683
Pallet: "runtime_common::auctions", Extrinsic: "cancel_auction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 7044
µs

Reads = 73
Writes = 3673
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 7044
µs

Reads = 73
Writes = 3673

@shawntabrizi shawntabrizi added C3-medium PR touches the given topic and has a medium impact on builders. B7-runtimenoteworthy D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. labels Jun 24, 2021
@shawntabrizi
Copy link
Member Author

/benchmark runtime kusama runtime_common::crowdloan

@shawntabrizi
Copy link
Member Author

/benchmark runtime westend runtime_common::crowdloan

…n=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_auctions.rs
@parity-benchapp
Copy link

parity-benchapp bot commented Jun 24, 2021

Finished benchmark for branch: shawntabrizi-check-bid

Benchmark: Benchmark Runtime Kusama Pallet

cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_crowdloan.rs

Results

Pallet: "runtime_common::crowdloan", Extrinsic: "create", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 93.53
µs

Reads = 4
Writes = 3
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 93.53
µs

Reads = 4
Writes = 3
Pallet: "runtime_common::crowdloan", Extrinsic: "contribute", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 581.4
µs

Reads = 7
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 581.4
µs

Reads = 7
Writes = 4
Pallet: "runtime_common::crowdloan", Extrinsic: "withdraw", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 127.5
µs

Reads = 4
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 127.5
µs

Reads = 4
Writes = 4
Pallet: "runtime_common::crowdloan", Extrinsic: "refund", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 0
+ k 56.64
µs

Reads = 3 + (2 * k)
Writes = 2 + (2 * k)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
k mean µs sigma µs %
0 923.1 3.853 0.4%
20 1219 5.065 0.4%
40 2308 9.311 0.4%
60 3363 5.825 0.1%
80 4463 7.992 0.1%
100 5562 15.79 0.2%
120 6620 24.4 0.3%
140 7789 16.62 0.2%
160 8863 18.69 0.2%
180 9829 19.73 0.2%
200 11000 23.25 0.2%
220 12160 38.56 0.3%
240 13350 26.92 0.2%
260 14400 36.85 0.2%
280 15440 29.05 0.1%
300 16680 80.07 0.4%
320 17650 46.39 0.2%
340 18940 48.27 0.2%
360 20080 45.11 0.2%
380 21050 37.61 0.1%
400 22410 86.54 0.3%
420 23540 63.83 0.2%
440 24810 31.33 0.1%
460 25890 54.06 0.2%
480 27070 94.32 0.3%
500 27820 68.23 0.2%
520 29260 72.03 0.2%
540 30690 69.59 0.2%
560 31520 123.1 0.3%
580 33080 81.02 0.2%
600 33790 106.2 0.3%
620 35160 139.4 0.3%
640 36090 106.6 0.2%
660 37090 60.98 0.1%
680 38170 98.85 0.2%
700 39630 117.6 0.2%
720 40560 92.37 0.2%
740 41530 92.55 0.2%
760 42510 86.41 0.2%
780 43650 104 0.2%
800 44070 44.63 0.1%
820 45930 137.3 0.2%
840 47490 122.5 0.2%
860 48470 127.5 0.2%
880 49960 125.1 0.2%
900 51300 157.7 0.3%
920 52440 140.1 0.2%
940 53960 79.34 0.1%
960 54820 117.3 0.2%
980 55840 162.5 0.2%
1000 56480 139.5 0.2%

Quality and confidence:
param error
k 0.052

Model:
Time ~= 0
+ k 56.71
µs

Reads = 3 + (2 * k)
Writes = 2 + (2 * k)
Pallet: "runtime_common::crowdloan", Extrinsic: "dissolve", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 68.75
µs

Reads = 2
Writes = 2
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 68.75
µs

Reads = 2
Writes = 2
Pallet: "runtime_common::crowdloan", Extrinsic: "edit", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 42.04
µs

Reads = 1
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 42.04
µs

Reads = 1
Writes = 1
Pallet: "runtime_common::crowdloan", Extrinsic: "add_memo", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 65.3
µs

Reads = 2
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 65.3
µs

Reads = 2
Writes = 1
Pallet: "runtime_common::crowdloan", Extrinsic: "poke", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 51.61
µs

Reads = 2
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 51.61
µs

Reads = 2
Writes = 1
Pallet: "runtime_common::crowdloan", Extrinsic: "on_initialize", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 0
+ n 131.8
µs

Reads = 5 + (5 * n)
Writes = 3 + (2 * n)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
n mean µs sigma µs %
2 279.8 0.746 0.2%
3 404.3 1.631 0.4%
4 538.8 1.3 0.2%
5 662.9 1.341 0.2%
6 791.7 0.784 0.0%
7 915 1.183 0.1%
8 1039 2.643 0.2%
9 1173 4.229 0.3%
10 1305 3.74 0.2%
11 1434 2.424 0.1%
12 1572 4.511 0.2%
13 1690 5.341 0.3%
14 1829 5.407 0.2%
15 1966 4.652 0.2%
16 2094 3.105 0.1%
17 2208 3.785 0.1%
18 2351 3.163 0.1%
19 2476 5.111 0.2%
20 2620 4.824 0.1%
21 2755 5.313 0.1%
22 2883 3.419 0.1%
23 3018 6.604 0.2%
24 3145 9.708 0.3%
25 3266 3.784 0.1%
26 3387 3.212 0.0%
27 3551 11.81 0.3%
28 3687 7.098 0.1%
29 3820 9.21 0.2%
30 3926 10.17 0.2%
31 4045 9.802 0.2%
32 4191 10.97 0.2%
33 4317 5.292 0.1%
34 4467 4.382 0.0%
35 4593 3.032 0.0%
36 4726 5.543 0.1%
37 4845 4.246 0.0%
38 4989 6.653 0.1%
39 5111 7.633 0.1%
40 5214 4.208 0.0%
41 5350 12.68 0.2%
42 5502 5.771 0.1%
43 5642 10.56 0.1%
44 5791 13.6 0.2%
45 5914 5.475 0.0%
46 6050 8.57 0.1%
47 6205 4.273 0.0%
48 6337 10.8 0.1%
49 6451 18.6 0.2%
50 6543 10.19 0.1%
51 6753 7.381 0.1%
52 6823 6.78 0.0%
53 6996 14.2 0.2%
54 7115 11.87 0.1%
55 7263 18.04 0.2%
56 7369 8.888 0.1%
57 7511 7.581 0.1%
58 7592 3.588 0.0%
59 7758 9.167 0.1%
60 7910 6.864 0.0%
61 8088 11.83 0.1%
62 8180 12.71 0.1%
63 8319 16.92 0.2%
64 8445 12.43 0.1%
65 8556 13.59 0.1%
66 8721 11.29 0.1%
67 8806 10.91 0.1%
68 8926 7.304 0.0%
69 9043 16.02 0.1%
70 9184 12.63 0.1%
71 9355 22.56 0.2%
72 9421 16.39 0.1%
73 9588 21.08 0.2%
74 9750 15.16 0.1%
75 9854 10.49 0.1%
76 9992 9.144 0.0%
77 10110 22.58 0.2%
78 10240 11.69 0.1%
79 10380 7.539 0.0%
80 10510 15.11 0.1%
81 10660 18.21 0.1%
82 10790 7.243 0.0%
83 10920 12.31 0.1%
84 11060 18.3 0.1%
85 11210 21.04 0.1%
86 11280 13.59 0.1%
87 11390 26.22 0.2%
88 11560 16.96 0.1%
89 11740 27.22 0.2%
90 11900 10.73 0.0%
91 12000 17.26 0.1%
92 12080 12.84 0.1%
93 12330 23.59 0.1%
94 12360 25.5 0.2%
95 12550 15.02 0.1%
96 12710 26.85 0.2%
97 12780 14.87 0.1%
98 12960 11.41 0.0%
99 13110 19.77 0.1%
100 13200 9.999 0.0%

Quality and confidence:
param error
n 0.032

Model:
Time ~= 0
+ n 131.9
µs

Reads = 5 + (5 * n)
Writes = 3 + (2 * n)

…n=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_crowdloan.rs
@parity-benchapp
Copy link

parity-benchapp bot commented Jun 24, 2021

Finished benchmark for branch: shawntabrizi-check-bid

Benchmark: Benchmark Runtime Westend Pallet

cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_auctions.rs

Results

Pallet: "runtime_common::auctions", Extrinsic: "new_auction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 29.96
µs

Reads = 2
Writes = 2
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 29.96
µs

Reads = 2
Writes = 2
Pallet: "runtime_common::auctions", Extrinsic: "bid", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 152.5
µs

Reads = 8
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 152.5
µs

Reads = 8
Writes = 4
Pallet: "runtime_common::auctions", Extrinsic: "on_initialize", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 32730
µs

Reads = 3688
Writes = 3683
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 32730
µs

Reads = 3688
Writes = 3683
Pallet: "runtime_common::auctions", Extrinsic: "cancel_auction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 7057
µs

Reads = 73
Writes = 3673
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 7057
µs

Reads = 73
Writes = 3673

@parity-benchapp
Copy link

parity-benchapp bot commented Jun 24, 2021

Finished benchmark for branch: shawntabrizi-check-bid

Benchmark: Benchmark Runtime Westend Pallet

cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_crowdloan.rs

Results

Pallet: "runtime_common::crowdloan", Extrinsic: "create", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 95.71
µs

Reads = 4
Writes = 3
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 95.71
µs

Reads = 4
Writes = 3
Pallet: "runtime_common::crowdloan", Extrinsic: "contribute", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 500.7
µs

Reads = 7
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 500.7
µs

Reads = 7
Writes = 4
Pallet: "runtime_common::crowdloan", Extrinsic: "withdraw", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 127.4
µs

Reads = 4
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 127.4
µs

Reads = 4
Writes = 4
Pallet: "runtime_common::crowdloan", Extrinsic: "refund", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 2.478
+ k 56
µs

Reads = 3 + (2 * k)
Writes = 2 + (2 * k)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
k mean µs sigma µs %
0 684.7 2.358 0.3%
10 705.7 2.711 0.3%
20 1228 8.416 0.6%
30 1759 3.752 0.2%
40 2281 15.73 0.6%
50 2831 8.84 0.3%
60 3380 11.93 0.3%
70 3935 6.855 0.1%
80 4483 12.18 0.2%
90 5013 12.19 0.2%
100 5505 12.97 0.2%
110 6135 16.76 0.2%
120 6696 15.47 0.2%
130 7258 19.67 0.2%
140 7830 19.37 0.2%
150 8307 18.86 0.2%
160 8845 16.77 0.1%
170 9448 20.95 0.2%
180 10010 30.98 0.3%
190 10480 26.27 0.2%
200 11110 30.27 0.2%
210 11560 25.06 0.2%
220 12180 25.55 0.2%
230 12830 28.54 0.2%
240 13470 49.65 0.3%
250 13900 27.76 0.1%
260 14450 47.92 0.3%
270 15070 38 0.2%
280 15700 18.96 0.1%
290 16150 37.33 0.2%
300 16700 85.56 0.5%
310 17380 21.35 0.1%
320 18020 52.83 0.2%
330 18350 34.98 0.1%
340 19100 41.72 0.2%
350 19700 83.89 0.4%
360 20260 45.95 0.2%
370 20790 48.88 0.2%
380 21420 57.19 0.2%
390 21890 45.52 0.2%
400 22590 43.73 0.1%
410 22930 62.46 0.2%
420 23310 53.87 0.2%
430 23870 93.03 0.3%
440 24370 57.38 0.2%
450 25400 62.72 0.2%
460 26270 84.69 0.3%
470 26650 109.2 0.4%
480 26950 106.3 0.3%
490 27760 66.94 0.2%
500 28150 54.16 0.1%

Quality and confidence:
param error
k 0.053

Model:
Time ~= 0
+ k 56.11
µs

Reads = 3 + (2 * k)
Writes = 2 + (2 * k)
Pallet: "runtime_common::crowdloan", Extrinsic: "dissolve", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 71.35
µs

Reads = 2
Writes = 2
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 71.35
µs

Reads = 2
Writes = 2
Pallet: "runtime_common::crowdloan", Extrinsic: "edit", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 43.19
µs

Reads = 1
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 43.19
µs

Reads = 1
Writes = 1
Pallet: "runtime_common::crowdloan", Extrinsic: "add_memo", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 65.64
µs

Reads = 2
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 65.64
µs

Reads = 2
Writes = 1
Pallet: "runtime_common::crowdloan", Extrinsic: "poke", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 51.08
µs

Reads = 2
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 51.08
µs

Reads = 2
Writes = 1
Pallet: "runtime_common::crowdloan", Extrinsic: "on_initialize", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 0
+ n 134.3
µs

Reads = 5 + (5 * n)
Writes = 3 + (2 * n)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
n mean µs sigma µs %
2 281.6 0.658 0.2%
3 408.3 0.611 0.1%
4 544 0.77 0.1%
5 672.2 0.903 0.1%
6 804.1 0.972 0.1%
7 932.5 1.573 0.1%
8 1060 3.421 0.3%
9 1192 2.187 0.1%
10 1325 4.032 0.3%
11 1462 2.762 0.1%
12 1590 3.115 0.1%
13 1719 3.504 0.2%
14 1856 2.784 0.1%
15 1996 2.954 0.1%
16 2124 4.009 0.1%
17 2250 7.331 0.3%
18 2389 4.178 0.1%
19 2526 7.5 0.2%
20 2658 7.462 0.2%
21 2798 4.821 0.1%
22 2925 4.413 0.1%
23 3067 4.345 0.1%
24 3198 7.132 0.2%
25 3329 5.395 0.1%
26 3473 13.25 0.3%
27 3596 6.285 0.1%
28 3732 11.03 0.2%
29 3869 4.978 0.1%
30 3973 3.837 0.0%
31 4123 5.13 0.1%
32 4274 10.18 0.2%
33 4395 4.824 0.1%
34 4541 7.513 0.1%
35 4682 11.13 0.2%
36 4796 11.11 0.2%
37 4963 5.253 0.1%
38 5074 7.686 0.1%
39 5209 8.204 0.1%
40 5340 10.68 0.2%
41 5486 8.837 0.1%
42 5599 5.176 0.0%
43 5747 8.895 0.1%
44 5915 10.41 0.1%
45 6036 10.64 0.1%
46 6170 8.005 0.1%
47 6286 7.542 0.1%
48 6453 13.79 0.2%
49 6518 6.175 0.0%
50 6705 7.514 0.1%
51 6868 23.03 0.3%
52 7003 9.435 0.1%
53 7109 18.8 0.2%
54 7257 6.437 0.0%
55 7370 9.459 0.1%
56 7511 14.49 0.1%
57 7671 16.34 0.2%
58 7795 29.88 0.3%
59 7910 15.04 0.1%
60 8042 20.91 0.2%
61 8166 14.11 0.1%
62 8285 11.82 0.1%
63 8472 24.15 0.2%
64 8569 9.271 0.1%
65 8725 15.95 0.1%
66 8841 18.99 0.2%
67 8997 13.79 0.1%
68 9100 10.35 0.1%
69 9240 7.797 0.0%
70 9385 22.55 0.2%
71 9501 21.87 0.2%
72 9623 15.15 0.1%
73 9725 21.85 0.2%
74 9938 11.37 0.1%
75 10040 14.34 0.1%
76 10170 11.07 0.1%
77 10310 16.39 0.1%
78 10440 21.45 0.2%
79 10580 10.75 0.1%
80 10670 18.42 0.1%
81 10850 13.27 0.1%
82 10960 11.42 0.1%
83 11100 20.46 0.1%
84 11210 16.09 0.1%
85 11390 12.4 0.1%
86 11540 19.23 0.1%
87 11630 17.76 0.1%
88 11830 18.08 0.1%
89 11970 22.09 0.1%
90 12110 28.22 0.2%
91 12230 20.06 0.1%
92 12380 31.81 0.2%
93 12470 18.6 0.1%
94 12610 17.67 0.1%
95 12790 12.37 0.0%
96 12920 14.15 0.1%
97 13130 19.44 0.1%
98 13200 23.52 0.1%
99 13300 16.6 0.1%
100 13430 14.36 0.1%

Quality and confidence:
param error
n 0.031

Model:
Time ~= 0
+ n 134.5
µs

Reads = 5 + (5 * n)
Writes = 3 + (2 * n)

Parity Bot added 2 commits June 24, 2021 22:48
…n=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_auctions.rs
…n=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_crowdloan.rs
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Also some more tests here, but I don't think they are necessary: #3365

@shawntabrizi
Copy link
Member Author

/benchmark runtime kusama runtime_common::slots

@parity-benchapp
Copy link

parity-benchapp bot commented Jun 25, 2021

Finished benchmark for branch: shawntabrizi-check-bid

Benchmark: Benchmark Runtime Kusama Pallet

cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::slots --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_slots.rs

Results

Pallet: "runtime_common::slots", Extrinsic: "force_lease", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 54.62
µs

Reads = 2
Writes = 2
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 54.62
µs

Reads = 2
Writes = 2
Pallet: "runtime_common::slots", Extrinsic: "manage_lease_period_start", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 0
+ c 19.56
+ t 42.7
µs

Reads = 4 + (1 * c) + (3 * t)
Writes = 1 + (1 * c) + (3 * t)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
c t mean µs sigma µs %
1 100 4153 8.343 0.2%
2 100 4190 14.63 0.3%
3 100 4215 18.24 0.4%
4 100 4116 9.965 0.2%
5 100 4154 10.69 0.2%
6 100 4202 13.1 0.3%
7 100 4224 9.063 0.2%
8 100 4190 7.806 0.1%
9 100 4312 14.29 0.3%
10 100 4270 24.08 0.5%
11 100 4260 21.35 0.5%
12 100 4299 21.19 0.4%
13 100 4362 24.6 0.5%
14 100 4385 18.31 0.4%
15 100 4434 15.37 0.3%
16 100 4406 24.57 0.5%
17 100 4402 12.67 0.2%
18 100 4422 23.55 0.5%
19 100 4482 17.52 0.3%
20 100 4514 11.97 0.2%
21 100 4464 9.999 0.2%
22 100 4501 34.79 0.7%
23 100 4589 11.15 0.2%
24 100 4561 27.78 0.6%
25 100 4525 9.906 0.2%
26 100 4637 14.57 0.3%
27 100 4536 11.78 0.2%
28 100 4681 14.82 0.3%
29 100 4687 20.45 0.4%
30 100 4685 11.19 0.2%
31 100 4690 13.99 0.2%
32 100 4681 17.57 0.3%
33 100 4780 15.44 0.3%
34 100 4765 27.5 0.5%
35 100 4764 12.14 0.2%
36 100 4763 14.77 0.3%
37 100 4804 22.85 0.4%
38 100 4760 16.89 0.3%
39 100 4814 18.12 0.3%
40 100 4890 10.17 0.2%
41 100 4888 10.78 0.2%
42 100 4848 9.595 0.1%
43 100 4884 23.84 0.4%
44 100 4952 16.74 0.3%
45 100 4963 23.7 0.4%
46 100 5023 13.34 0.2%
47 100 5002 20.88 0.4%
48 100 5061 7.998 0.1%
49 100 5055 24.82 0.4%
50 100 5039 34.17 0.6%
51 100 5024 16.4 0.3%
52 100 5105 20.18 0.3%
53 100 5105 8.357 0.1%
54 100 5145 15.16 0.2%
55 100 5166 33.87 0.6%
56 100 5225 22.19 0.4%
57 100 5116 14.34 0.2%
58 100 5250 13.6 0.2%
59 100 5193 17.89 0.3%
60 100 5249 17.46 0.3%
61 100 5307 26.37 0.4%
62 100 5281 43.17 0.8%
63 100 5336 16.95 0.3%
64 100 5367 10.27 0.1%
65 100 5438 18.21 0.3%
66 100 5299 10.63 0.2%
67 100 5408 13.39 0.2%
68 100 5352 18.45 0.3%
69 100 5462 12.28 0.2%
70 100 5436 32.78 0.6%
71 100 5462 28.61 0.5%
72 100 5497 17.52 0.3%
73 100 5484 22.05 0.4%
74 100 5586 16.33 0.2%
75 100 5593 42.9 0.7%
76 100 5609 30.13 0.5%
77 100 5516 17.46 0.3%
78 100 5559 19.12 0.3%
79 100 5614 29.95 0.5%
80 100 5637 22.5 0.3%
81 100 5564 19.91 0.3%
82 100 5698 14.13 0.2%
83 100 5789 8.318 0.1%
84 100 5769 9.85 0.1%
85 100 5745 15.06 0.2%
86 100 5785 26.66 0.4%
87 100 5710 18.41 0.3%
88 100 5819 33.61 0.5%
89 100 5855 7.842 0.1%
90 100 5864 18.74 0.3%
91 100 5909 44.24 0.7%
92 100 5915 18.17 0.3%
93 100 5896 27.03 0.4%
94 100 5886 20.64 0.3%
95 100 5972 8.922 0.1%
96 100 6028 11.24 0.1%
97 100 6041 33.67 0.5%
98 100 6015 19.18 0.3%
99 100 5975 8.389 0.1%
100 1 1822 1.842 0.1%
100 2 1888 4.804 0.2%
100 3 1920 3.871 0.2%
100 4 1986 4.148 0.2%
100 5 1994 8.688 0.4%
100 6 2040 3.059 0.1%
100 7 2088 4.129 0.1%
100 8 2117 4.802 0.2%
100 9 2149 3.254 0.1%
100 10 2212 5.173 0.2%
100 11 2275 4.198 0.1%
100 12 2302 3.907 0.1%
100 13 2315 5.028 0.2%
100 14 2367 11.95 0.5%
100 15 2397 5.369 0.2%
100 16 2420 5.276 0.2%
100 17 2523 5.597 0.2%
100 18 2540 6.251 0.2%
100 19 2578 8.331 0.3%
100 20 2609 6.403 0.2%
100 21 2637 6.804 0.2%
100 22 2669 3.793 0.1%
100 23 2750 9.696 0.3%
100 24 2810 14.36 0.5%
100 25 2798 8.835 0.3%
100 26 2865 12.06 0.4%
100 27 2942 5.549 0.1%
100 28 2931 10.78 0.3%
100 29 2992 14.15 0.4%
100 30 3035 6.91 0.2%
100 31 3036 5.681 0.1%
100 32 3067 4.58 0.1%
100 33 3161 11.07 0.3%
100 34 3158 7.879 0.2%
100 35 3242 12.49 0.3%
100 36 3260 15.99 0.4%
100 37 3312 8.219 0.2%
100 38 3390 8.877 0.2%
100 39 3402 14.44 0.4%
100 40 3454 12.21 0.3%
100 41 3483 11.63 0.3%
100 42 3541 10.28 0.2%
100 43 3572 5.746 0.1%
100 44 3568 7.453 0.2%
100 45 3674 10.75 0.2%
100 46 3664 5.618 0.1%
100 47 3761 10.39 0.2%
100 48 3818 8.878 0.2%
100 49 3848 7.605 0.1%
100 50 3884 8.788 0.2%
100 51 3886 5.884 0.1%
100 52 3991 17.81 0.4%
100 53 3987 11.4 0.2%
100 54 4055 18.9 0.4%
100 55 4098 23.01 0.5%
100 56 4154 16.94 0.4%
100 57 4148 13.26 0.3%
100 58 4243 23.35 0.5%
100 59 4253 14 0.3%
100 60 4312 31.4 0.7%
100 61 4372 19.21 0.4%
100 62 4420 5.035 0.1%
100 63 4429 23.38 0.5%
100 64 4499 25.45 0.5%
100 65 4568 14.41 0.3%
100 66 4578 18.99 0.4%
100 67 4631 12.14 0.2%
100 68 4614 29.49 0.6%
100 69 4657 10.72 0.2%
100 70 4699 10.22 0.2%
100 71 4719 14.63 0.3%
100 72 4797 22 0.4%
100 73 4883 28.01 0.5%
100 74 4879 21.45 0.4%
100 75 4936 17.72 0.3%
100 76 4973 30.46 0.6%
100 77 5063 17.75 0.3%
100 78 5074 29.97 0.5%
100 79 5081 11.4 0.2%
100 80 5189 9.15 0.1%
100 81 5218 28.82 0.5%
100 82 5311 13.47 0.2%
100 83 5315 25.97 0.4%
100 84 5359 24.09 0.4%
100 85 5374 25.36 0.4%
100 86 5450 13.98 0.2%
100 87 5507 17.9 0.3%
100 88 5555 26.84 0.4%
100 89 5655 16.4 0.2%
100 90 5673 15.84 0.2%
100 91 5629 15.08 0.2%
100 92 5749 19.69 0.3%
100 93 5783 10.27 0.1%
100 94 5778 19.69 0.3%
100 95 5921 12.57 0.2%
100 96 5871 20.93 0.3%
100 97 6012 19.95 0.3%
100 98 5905 18.96 0.3%
100 99 6050 4.331 0.0%
100 100 6082 29.59 0.4%

Quality and confidence:
param error
c 0.036
t 0.036

Model:
Time ~= 0
+ c 19.52
+ t 42.88
µs

Reads = 4 + (1 * c) + (3 * t)
Writes = 1 + (1 * c) + (3 * t)
Pallet: "runtime_common::slots", Extrinsic: "clear_all_leases", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 230.3
µs

Reads = 9
Writes = 9
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 230.3
µs

Reads = 9
Writes = 9
Pallet: "runtime_common::slots", Extrinsic: "trigger_onboard", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 45.88
µs

Reads = 5
Writes = 3
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 45.88
µs

Reads = 5
Writes = 3

@shawntabrizi
Copy link
Member Author

/benchmark runtime westend runtime_common::slots

…n=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::slots --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_slots.rs
@parity-benchapp
Copy link

parity-benchapp bot commented Jun 25, 2021

Finished benchmark for branch: shawntabrizi-check-bid

Benchmark: Benchmark Runtime Westend Pallet

cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::slots --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_slots.rs

Results

Pallet: "runtime_common::slots", Extrinsic: "force_lease", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 53.93
µs

Reads = 2
Writes = 2
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 53.93
µs

Reads = 2
Writes = 2
Pallet: "runtime_common::slots", Extrinsic: "manage_lease_period_start", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 0
+ c 19.64
+ t 42.22
µs

Reads = 4 + (1 * c) + (3 * t)
Writes = 1 + (1 * c) + (3 * t)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
c t mean µs sigma µs %
1 100 4053 9.682 0.2%
2 100 4113 21.83 0.5%
3 100 4123 11.07 0.2%
4 100 4222 12.34 0.2%
5 100 4178 10.95 0.2%
6 100 4133 7.522 0.1%
7 100 4250 8.786 0.2%
8 100 4270 11.6 0.2%
9 100 4302 12.27 0.2%
10 100 4306 9.554 0.2%
11 100 4367 14.44 0.3%
12 100 4260 10.39 0.2%
13 100 4316 19.4 0.4%
14 100 4327 11.88 0.2%
15 100 4413 14.33 0.3%
16 100 4372 11.63 0.2%
17 100 4402 16.75 0.3%
18 100 4412 5.843 0.1%
19 100 4436 16.94 0.3%
20 100 4405 16.98 0.3%
21 100 4402 17.13 0.3%
22 100 4503 16.13 0.3%
23 100 4500 10.02 0.2%
24 100 4509 12.96 0.2%
25 100 4534 16.13 0.3%
26 100 4544 23.59 0.5%
27 100 4579 24.07 0.5%
28 100 4659 6.796 0.1%
29 100 4635 19.73 0.4%
30 100 4558 9.306 0.2%
31 100 4592 14.13 0.3%
32 100 4676 32.96 0.7%
33 100 4743 9.765 0.2%
34 100 4691 16.35 0.3%
35 100 4716 11.35 0.2%
36 100 4692 12.9 0.2%
37 100 4750 15.21 0.3%
38 100 4874 20.62 0.4%
39 100 4803 23.48 0.4%
40 100 4816 20.19 0.4%
41 100 4798 8.568 0.1%
42 100 4875 9.075 0.1%
43 100 4946 18.89 0.3%
44 100 4844 13.71 0.2%
45 100 4963 19.24 0.3%
46 100 5041 10.9 0.2%
47 100 4965 16.29 0.3%
48 100 5001 17.91 0.3%
49 100 5027 8.574 0.1%
50 100 5002 18.43 0.3%
51 100 5069 10.39 0.2%
52 100 5154 9.944 0.1%
53 100 5121 15.37 0.3%
54 100 5170 14.79 0.2%
55 100 5100 11.31 0.2%
56 100 5139 19.41 0.3%
57 100 5271 5.016 0.0%
58 100 5207 21.26 0.4%
59 100 5264 16.44 0.3%
60 100 5243 24.3 0.4%
61 100 5246 19.43 0.3%
62 100 5296 9.925 0.1%
63 100 5301 19.49 0.3%
64 100 5331 10.17 0.1%
65 100 5417 18.74 0.3%
66 100 5298 17.45 0.3%
67 100 5371 30.99 0.5%
68 100 5321 5.756 0.1%
69 100 5377 17.69 0.3%
70 100 5415 26.26 0.4%
71 100 5469 15.46 0.2%
72 100 5443 18.56 0.3%
73 100 5471 37.78 0.6%
74 100 5480 10.29 0.1%
75 100 5548 47.7 0.8%
76 100 5490 14.26 0.2%
77 100 5582 21.35 0.3%
78 100 5510 21.5 0.3%
79 100 5643 27.38 0.4%
80 100 5646 22.34 0.3%
81 100 5683 29.2 0.5%
82 100 5733 13 0.2%
83 100 5723 32.45 0.5%
84 100 5749 37.22 0.6%
85 100 5776 32.6 0.5%
86 100 5796 22.86 0.3%
87 100 5738 14.97 0.2%
88 100 5786 46.78 0.8%
89 100 5836 12.5 0.2%
90 100 5834 15.05 0.2%
91 100 5870 19.06 0.3%
92 100 5922 11.44 0.1%
93 100 5863 11.22 0.1%
94 100 5889 22.86 0.3%
95 100 5927 18.58 0.3%
96 100 5949 39.09 0.6%
97 100 5997 30.1 0.5%
98 100 5923 13.43 0.2%
99 100 5955 17.68 0.2%
100 1 1874 8.23 0.4%
100 2 1934 9.025 0.4%
100 3 1947 4.209 0.2%
100 4 1989 3.455 0.1%
100 5 2040 2.811 0.1%
100 6 2104 3.89 0.1%
100 7 2119 4.561 0.2%
100 8 2140 4.569 0.2%
100 9 2193 4.76 0.2%
100 10 2252 5.315 0.2%
100 11 2300 3.509 0.1%
100 12 2314 2.656 0.1%
100 13 2356 4.866 0.2%
100 14 2410 5.12 0.2%
100 15 2465 5.19 0.2%
100 16 2511 3.907 0.1%
100 17 2550 3.781 0.1%
100 18 2576 9.052 0.3%
100 19 2617 6.121 0.2%
100 20 2661 3.287 0.1%
100 21 2708 4.897 0.1%
100 22 2786 9.598 0.3%
100 23 2815 9.435 0.3%
100 24 2874 4.961 0.1%
100 25 2838 7.943 0.2%
100 26 2917 6.379 0.2%
100 27 2967 7.317 0.2%
100 28 3016 11.02 0.3%
100 29 2982 11.64 0.3%
100 30 3085 17.46 0.5%
100 31 3135 8.276 0.2%
100 32 3149 11.11 0.3%
100 33 3161 12.68 0.4%
100 34 3214 14.91 0.4%
100 35 3267 10.73 0.3%
100 36 3258 10.16 0.3%
100 37 3310 5.903 0.1%
100 38 3416 13.36 0.3%
100 39 3432 10.9 0.3%
100 40 3438 7.788 0.2%
100 41 3502 9.279 0.2%
100 42 3567 15.05 0.4%
100 43 3583 5.348 0.1%
100 44 3649 13.31 0.3%
100 45 3725 12.73 0.3%
100 46 3721 17.64 0.4%
100 47 3761 20.32 0.5%
100 48 3819 20.19 0.5%
100 49 3915 6.788 0.1%
100 50 3911 10.04 0.2%
100 51 3968 12.25 0.3%
100 52 4053 5.977 0.1%
100 53 4085 8.963 0.2%
100 54 4009 7.457 0.1%
100 55 4067 7.578 0.1%
100 56 4155 15.06 0.3%
100 57 4267 7.011 0.1%
100 58 4252 5.176 0.1%
100 59 4339 7.508 0.1%
100 60 4340 16.83 0.3%
100 61 4379 15.88 0.3%
100 62 4414 24.49 0.5%
100 63 4400 9.118 0.2%
100 64 4492 17.2 0.3%
100 65 4539 11.27 0.2%
100 66 4542 6.961 0.1%
100 67 4647 16.92 0.3%
100 68 4695 9.791 0.2%
100 69 4738 10.11 0.2%
100 70 4707 14.69 0.3%
100 71 4815 14.61 0.3%
100 72 4844 27.99 0.5%
100 73 4966 15.86 0.3%
100 74 4980 30.64 0.6%
100 75 4978 21.14 0.4%
100 76 5051 12.34 0.2%
100 77 4979 8.305 0.1%
100 78 5150 18.38 0.3%
100 79 5128 26.19 0.5%
100 80 5177 29.26 0.5%
100 81 5222 28.62 0.5%
100 82 5325 31.87 0.5%
100 83 5260 9.37 0.1%
100 84 5344 28.52 0.5%
100 85 5443 10.58 0.1%
100 86 5422 30.46 0.5%
100 87 5556 20.48 0.3%
100 88 5581 27.65 0.4%
100 89 5592 37.98 0.6%
100 90 5598 22.78 0.4%
100 91 5651 15.58 0.2%
100 92 5773 15.14 0.2%
100 93 5712 15.33 0.2%
100 94 5847 52.5 0.8%
100 95 5839 46.9 0.8%
100 96 5905 29.56 0.5%
100 97 5855 10.1 0.1%
100 98 5981 26.12 0.4%
100 99 6024 22.5 0.3%
100 100 6069 12.16 0.2%

Quality and confidence:
param error
c 0.037
t 0.037

Model:
Time ~= 0
+ c 19.72
+ t 42.18
µs

Reads = 4 + (1 * c) + (3 * t)
Writes = 1 + (1 * c) + (3 * t)
Pallet: "runtime_common::slots", Extrinsic: "clear_all_leases", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 249.5
µs

Reads = 9
Writes = 9
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 249.5
µs

Reads = 9
Writes = 9
Pallet: "runtime_common::slots", Extrinsic: "trigger_onboard", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 49.69
µs

Reads = 5
Writes = 3
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 49.69
µs

Reads = 5
Writes = 3

…n=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::slots --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_slots.rs
@s3krit
Copy link
Contributor

s3krit commented Jun 25, 2021

bot merge

@ghost
Copy link

ghost commented Jun 25, 2021

Waiting for commit status.

@ghost ghost merged commit 2c44780 into master Jun 25, 2021
@ghost ghost deleted the shawntabrizi-check-bid branch June 25, 2021 10:56
s3krit added a commit that referenced this pull request Jun 25, 2021
…iod (#3361)

* add already leased

Co-Authored-By: parity-processbot <>

* add unit test

Co-Authored-By: parity-processbot <>

* add integration test and fix

Co-Authored-By: parity-processbot <>

* better doc

Co-Authored-By: parity-processbot <>

* Update runtime/common/src/slots.rs

* Update runtime/common/src/slots.rs

* Apply suggestions from code review

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update runtime/common/src/integration_tests.rs

* Update runtime/common/src/integration_tests.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_auctions.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_auctions.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_crowdloan.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_auctions.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_crowdloan.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::slots --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_slots.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::slots --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_slots.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Parity Bot <admin@parity.io>
@s3krit s3krit mentioned this pull request Jun 25, 2021
s3krit added a commit that referenced this pull request Jun 25, 2021
* Don't allow bids for a ParaId where there is an overlapping lease period (#3361)

* add already leased

Co-Authored-By: parity-processbot <>

* add unit test

Co-Authored-By: parity-processbot <>

* add integration test and fix

Co-Authored-By: parity-processbot <>

* better doc

Co-Authored-By: parity-processbot <>

* Update runtime/common/src/slots.rs

* Update runtime/common/src/slots.rs

* Apply suggestions from code review

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update runtime/common/src/integration_tests.rs

* Update runtime/common/src/integration_tests.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_auctions.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_auctions.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_crowdloan.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_auctions.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_crowdloan.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::slots --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_slots.rs

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_common::slots --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_common_slots.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Parity Bot <admin@parity.io>

* Bump versions & spec_versions (#3368)

* bump versions & spec_versions

* bump Cargo.lock

* update to use v0.9.7 beefy and substrate branches

* remove old migrations

* remove SetStakingLimits from polkadot, give kian a heartattack

* oops

* fix

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Parity Bot <admin@parity.io>
@mmostafas mmostafas added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jun 28, 2021
ordian added a commit that referenced this pull request Jul 2, 2021
* master: (21 commits)
  cleanup stream polls (#3397)
  Staking Miner (#3141)
  Companion for Substrate#8953 (#3140)
  Bump version, specs & substrate in prep for v0.9.8 (#3387)
  Fix busy loops. (#3392)
  Minor refactor (#3386)
  add simnet tests (#3381)
  BEEFY: adjust gossip (#3372)
  Companion for #9193 (#3376)
  Companion for Decouple Staking and Election - Part 3: Signed Phase (#2793)
  Ensure that we fetch another collation if the first collation was invalid (#3362)
  Only send one collation per relay parent at a time to validators (#3360)
  disable approval-checking-grandpa on dev chain (#3364)
  Use associated constant for max (#3375)
  Use wasm-builder from git (#3354)
  Squashed 'bridges/' changes from b2099c5..23dda62 (#3369)
  Bump versions & spec_versions (#3368)
  Don't allow bids for a ParaId where there is an overlapping lease period (#3361)
  Companion for upgrade of transaction-payment to pallet macro (#3267)
  Do not allow any crowdloan contributions during the VRF period (#3346)
  ...
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C3-medium PR touches the given topic and has a medium impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants