This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't allow bids for a ParaId where there is an overlapping lease period #3361
Don't allow bids for a ParaId where there is an overlapping lease period #3361
Changes from 4 commits
716e160
d4b3f90
be4014d
e33e1b7
b683233
9aa5309
62e800b
0051604
6d6f47d
93dea24
63f5db5
1724b94
ba1f1d3
35cfc7a
8b6f38e
4a196e2
649f0ff
54437cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may be slightly incorrect: technically our implementation in slots only can check the current lease period and onwards. So if any periods in
first_period..=last_period
are in the past we will not be able to look at those. Additionally we will always returnfalse
if the entire range is in the past (I don't think this is an issue but just wanted to point it out)