This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
remove Default from CandidateDescriptor #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
ordian
reviewed
Dec 7, 2021
drahnr
added
B0-silent
ordian
added
the
D3-trivial 🧸
Co-authored-by: Andronik Ordian <write@reusable.software>
emostov
reviewed
Dec 10, 2021
primitives/test-helpers/src/lib.rs
Outdated
|
|
||
| /// Create meaningless dummy hash. | ||
| pub fn dummy_hash() -> Hash { | ||
| // TODO make this PRNG based |
There was a problem hiding this comment.
@drahnr are you ok with leaving this out for now and leaving for a follow up?
There was a problem hiding this comment.
It would make things a little more complicated because we would no longer be able to use this when we are asserting the output
There was a problem hiding this comment.
Please remove the TODOs, it's fine for right now, and I think we should introduce a separate fn with _rand suffix
|
/benchmark runtime kusama runtime_parachains::paras_inherent |
|
Benchmark Runtime Kusama Pallet for branch "bernhard-avoid-default-for-bench-and-tests" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras_inherent.rs Results |
…bernhard-avoid-default-for-bench-and-tests
emostov
reviewed
Dec 10, 2021
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras_inherent.rs
emostov
reviewed
Dec 10, 2021
| // Standard Error: 26_000 | ||
| .saturating_add((49_051_000 as Weight).saturating_mul(v as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads(29 as Weight)) | ||
| (1_134_397_000 as Weight) |
There was a problem hiding this comment.
3x increase to the static weight here is quite significant
There was a problem hiding this comment.
I don't quite understand where that comes from
|
/benchmark runtime polkadot runtime_parachains::paras_inherent |
|
Benchmark Runtime Polkadot Pallet for branch "bernhard-avoid-default-for-bench-and-tests" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras_inherent.rs Results |
…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras_inherent.rs
gavofyork
reviewed
Dec 10, 2021
gavofyork
reviewed
Dec 10, 2021
| @@ -47,7 +47,7 @@ fn dummy_validation_code() -> ValidationCode { | |||
| /// "features = runtime-benchmarks". | |||
| fn account<AccountId: Decode + Default>(name: &'static str, index: u32, seed: u32) -> AccountId { | |||
| let entropy = (name, index, seed).using_encoded(sp_io::hashing::blake2_256); | |||
| AccountId::decode(&mut &entropy[..]).unwrap_or_default() | |||
| AccountId::decode(&mut &entropy[..]).expect("256 bit input is valid. qed.") | |||
There was a problem hiding this comment.
This is fine for now, but in general it's best to use TrailZeroInput to ensure that AccountId::decode doesn't run out of input data. In the future, we should just have a trait function for fn from_entropy(e: impl Encode) -> Self.
gavofyork
reviewed
Dec 10, 2021
| (201_142_000 as Weight) | ||
| // Standard Error: 2_000 | ||
| .saturating_add((304_000 as Weight).saturating_mul(v as Weight)) | ||
| (404_051_000 as Weight) |
There was a problem hiding this comment.
It's unclear to what caused this, or if other changes on master caused the change, to be checked.
gavofyork
approved these changes
Dec 10, 2021
eskimor
reviewed
Dec 10, 2021
eskimor
approved these changes
Dec 10, 2021
|
bot merge |
|
Waiting for commit status. |
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
bernhard-avoid-default-for-bench-and-tests
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a set of helpers for testing to create
Candidate*-types with ease. The purpose of these types twofold, 1) subsystem unit tests which are in need of unified fillers, that create types which can have arbitrary content 2) for benchmarking where the content has influence on the measured runtime.@emostov please take over and drive this to completion ASAP
TODOs
fn dummy() -> Selfimplementations @emostov`sr25519_sign_version_1` called outside of an Externalities-provided environment.', needs a fixfns into the the test helper crate (i.e.CandidateBuilderis a good candidate, there are 4 or 5 copies of that. AlsoSessionInfo) @drahnr , can be defered to a follow up PRdummy_*calls in there @emostovx: Default::default()usage as much as possible @drahnrRef paritytech/substrate#10403
skip check-dependent-cumulus