Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

staking-miner: CLI flag delay solution x secs #5734

Merged
merged 10 commits into from
Jun 30, 2022
Merged

staking-miner: CLI flag delay solution x secs #5734

merged 10 commits into from
Jun 30, 2022

Conversation

niklasad1
Copy link
Member

No description provided.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jun 27, 2022
@niklasad1 niklasad1 added B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. labels Jun 27, 2022
@kianenigma
Copy link
Contributor

Can you also double check that:

  1. We do read the status of the UPDATED queue before submitting,
  2. and that if we observe a solution in it with the same score as what we have submitted,
  3. or if it is actually full
  4. we emit a log, and we don't submit?

@niklasad1
Copy link
Member Author

niklasad1 commented Jun 29, 2022 •
edited
Loading

Can you also double check that:

  1. We do read the status of the UPDATED queue before submitting,
  2. and that if we observe a solution in it with the same score as what we have submitted,
  3. or if it is actually full
  4. we emit a log, and we don't submit?
  1. Yes, that has been done all the time but I added that we read that the current account hasn't submitted in that round as well.
  2. Added a log if that occurs but as if-leading stategy is used by default nothing will be sent if the scores as equal, as we compare the scores with ElectionScore::strict_better_better(other, episilon)
  3. If it's better we will still submit but added a log if the queue is full.
  4. Yes added.

dvdplm
dvdplm approved these changes Jun 30, 2022
View reviewed changes
utils/staking-miner/src/opts.rs Outdated Show resolved Hide resolved
utils/staking-miner/src/opts.rs Outdated Show resolved Hide resolved
niklasad1 and others added 3 commits June 30, 2022 10:33
@niklasad1 @dvdplm
Update utils/staking-miner/src/opts.rs
efade43 
Co-authored-by: David <dvdplm@gmail.com>
@niklasad1 @dvdplm
Update utils/staking-miner/src/opts.rs
87a4a13 
Co-authored-by: David <dvdplm@gmail.com>
@niklasad1
remove redundant check
9cc1cce
@niklasad1
Copy link
Member Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit f7d808e into master Jun 30, 2022
@paritytech-processbot paritytech-processbot bot deleted the na-staking-miner-delay-solution branch June 30, 2022 10:46
pepoviola pushed a commit that referenced this pull request Jul 3, 2022
@niklasad1 @dvdplm @pepoviola
staking-miner: CLI flag delay solution x secs (#5734)
83baccb 
* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>
ordian added a commit that referenced this pull request Jul 5, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
650eb19 
* master:
  Fix regexp to find the repo name (#5751)
  Limit stagnant checks to a certain amount of entries (#5742)
  fix(staking miner): check latest state in solution (#5744)
  staking-miner: CLI flag delay solution x secs (#5734)
  backport minimum weight to fee to master (#5739)
  Bump quote from 1.0.19 to 1.0.20 (#5736)
paritytech-processbot bot pushed a commit that referenced this pull request Jul 5, 2022
@pepoviola @sandreim
@alvicsam @dependabot @kianenigma @niklasad1 @dvdplm @chevdor
[Zombienet] test deregister validator (#5718)
fb2c9ae 
* Update metric name and doc

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* add test and rename metric to use

* change within time for test

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Properly format the stash account

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* Update test

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* change metric name

* Bump quote from 1.0.19 to 1.0.20 (#5736)

Bumps [quote](https://github.com/dtolnay/quote) from 1.0.19 to 1.0.20.
- [Release notes](https://github.com/dtolnay/quote/releases)
- [Commits](dtolnay/quote@1.0.19...1.0.20)

---
updated-dependencies:
- dependency-name: quote
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* backport minimum weight to fee to master (#5739)

* propose fix fees

* add tests to kusama runtime as well

* better tests

* last change

* last update

* Fix test

* ignore tests again

* staking-miner: CLI flag delay solution x secs (#5734)

* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>

* fix(staking miner): check latest state in solution (#5744)

* bump zombienet version and fix test

* Update zombienet_tests/smoke/0003-deregister-register-validator-smoke.toml

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

* Update zombienet_tests/smoke/0003-deregister-register-validator.js

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

Co-authored-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
niklasad1 added a commit that referenced this pull request Jul 6, 2022
@niklasad1 @dvdplm
staking-miner: CLI flag delay solution x secs (#5734)
15317c7 
* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>
ordian added a commit that referenced this pull request Jul 12, 2022
@ordian
Merge branch 'master' into bernhard-split-network-bridge-into-two-sub…
687ae9a 
…systems

* master: (39 commits)
  Implement prune only stagnant check mode (#5761)
  Bump chevdor/srtool-actions from 0.4.0 to 0.5.0 (#5769)
  Update release-99_bot.yml (#5764)
  Version bump to v0.9.26/9260 (#5755)
  Rename `extra_constant` (#5749)
  Bump wasmtime from 0.38.0 to 0.38.1 (#5741)
  Several small fixes to the templates of the release notes (#5756)
  Backports from 0.9.25 (#5754)
  Remove bridges subtree (#5752)
  [Zombienet] test deregister validator (#5718)
  Fix regexp to find the repo name (#5751)
  Limit stagnant checks to a certain amount of entries (#5742)
  fix(staking miner): check latest state in solution (#5744)
  staking-miner: CLI flag delay solution x secs (#5734)
  backport minimum weight to fee to master (#5739)
  Bump quote from 1.0.19 to 1.0.20 (#5736)
  zombienet: try to fix parachains upgrade test (#5724)
  Update dependencies (companion for substrate#11722) (#5731)
  Update metric name and doc (#5716)
  Bump reqwest from 0.11.10 to 0.11.11 (#5732)
  ...
al3mart pushed a commit that referenced this pull request Jul 14, 2022
@niklasad1 @dvdplm
staking-miner: CLI flag delay solution x secs (#5734)
1b14d4d 
* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>
al3mart pushed a commit that referenced this pull request Jul 14, 2022
@pepoviola @sandreim
@alvicsam @dependabot @kianenigma @niklasad1 @dvdplm @chevdor
[Zombienet] test deregister validator (#5718)
0d1f8f8 
* Update metric name and doc

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* add test and rename metric to use

* change within time for test

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Properly format the stash account

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* Update test

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* change metric name

* Bump quote from 1.0.19 to 1.0.20 (#5736)

Bumps [quote](https://github.com/dtolnay/quote) from 1.0.19 to 1.0.20.
- [Release notes](https://github.com/dtolnay/quote/releases)
- [Commits](dtolnay/quote@1.0.19...1.0.20)

---
updated-dependencies:
- dependency-name: quote
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* backport minimum weight to fee to master (#5739)

* propose fix fees

* add tests to kusama runtime as well

* better tests

* last change

* last update

* Fix test

* ignore tests again

* staking-miner: CLI flag delay solution x secs (#5734)

* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>

* fix(staking miner): check latest state in solution (#5744)

* bump zombienet version and fix test

* Update zombienet_tests/smoke/0003-deregister-register-validator-smoke.toml

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

* Update zombienet_tests/smoke/0003-deregister-register-validator.js

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

Co-authored-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
@librelois librelois mentioned this pull request Jul 19, 2022
Closed
@niklasad1 niklasad1 mentioned this pull request Dec 9, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @kianenigma @dvdplm