This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Limit stagnant checks to a certain amount of entries #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will likely be required if we enable stagnant prunning as currently database has way too many entries to be prunned in a single iteration
vstakhov
added
A0-please_review
sandreim
reviewed
Jun 30, 2022
eskimor
approved these changes
Jun 30, 2022
sandreim
approved these changes
Jun 30, 2022
|
bot merge |
ordian
added a commit
that referenced
this pull request
Jul 5, 2022
* master: Fix regexp to find the repo name (#5751) Limit stagnant checks to a certain amount of entries (#5742) fix(staking miner): check latest state in solution (#5744) staking-miner: CLI flag delay solution x secs (#5734) backport minimum weight to fee to master (#5739) Bump quote from 1.0.19 to 1.0.20 (#5736)
ordian
added a commit
that referenced
this pull request
Jul 12, 2022
…systems * master: (39 commits) Implement prune only stagnant check mode (#5761) Bump chevdor/srtool-actions from 0.4.0 to 0.5.0 (#5769) Update release-99_bot.yml (#5764) Version bump to v0.9.26/9260 (#5755) Rename `extra_constant` (#5749) Bump wasmtime from 0.38.0 to 0.38.1 (#5741) Several small fixes to the templates of the release notes (#5756) Backports from 0.9.25 (#5754) Remove bridges subtree (#5752) [Zombienet] test deregister validator (#5718) Fix regexp to find the repo name (#5751) Limit stagnant checks to a certain amount of entries (#5742) fix(staking miner): check latest state in solution (#5744) staking-miner: CLI flag delay solution x secs (#5734) backport minimum weight to fee to master (#5739) Bump quote from 1.0.19 to 1.0.20 (#5736) zombienet: try to fix parachains upgrade test (#5724) Update dependencies (companion for substrate#11722) (#5731) Update metric name and doc (#5716) Bump reqwest from 0.11.10 to 0.11.11 (#5732) ...
al3mart
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Limit number of elements loaded from the stagnant key This will likely be required if we enable stagnant prunning as currently database has way too many entries to be prunned in a single iteration * Fmt run * Slightly improve logging * Some more debug nits * Fmt pass
al3mart
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Limit number of elements loaded from the stagnant key This will likely be required if we enable stagnant prunning as currently database has way too many entries to be prunned in a single iteration * Fmt run * Slightly improve logging * Some more debug nits * Fmt pass
3 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the stagnant checks are in the
nevermode, which means that stagnant entires are constantly stored in the database and never wiped up. If stagnant checks got enabled, that would lead to potential issues with memory/time, so it might be good to limit number of entries by some sane amount per iteration.