Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

asset-conversion pallet: Generalise integrity test #14289

Merged
merged 3 commits into from
Jun 2, 2023
Merged

asset-conversion pallet: Generalise integrity test #14289

merged 3 commits into from
Jun 2, 2023

Conversation

gilescope
Copy link
Contributor

Integrity test was only working for u32 types. Switch to using the BenchmarkHelper that knows how to construct asset ids from integers.

@gilescope gilescope added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 2, 2023
@gilescope gilescope requested review from a team June 2, 2023 10:34
@gilescope gilescope requested a review from jsidorenko June 2, 2023 10:39
jsidorenko
jsidorenko approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@jsidorenko jsidorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jsidorenko
jsidorenko approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@jsidorenko jsidorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

ggwpez
ggwpez reviewed Jun 2, 2023
View reviewed changes
frame/asset-conversion/src/lib.rs Show resolved Hide resolved
frame/asset-conversion/src/lib.rs Outdated Show resolved Hide resolved
@gilescope @ggwpez
Update frame/asset-conversion/src/lib.rs
fc763fb 
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@gilescope
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

bkchr
bkchr reviewed Jun 2, 2023
View reviewed changes
frame/asset-conversion/src/lib.rs Show resolved Hide resolved
frame/asset-conversion/src/lib.rs Show resolved Hide resolved
frame/asset-conversion/src/lib.rs Show resolved Hide resolved
frame/asset-conversion/src/lib.rs Show resolved Hide resolved
@paritytech-processbot paritytech-processbot bot merged commit f4d19a3 into master Jun 2, 2023
@paritytech-processbot paritytech-processbot bot deleted the giles-generalise-integrity-test branch June 2, 2023 12:54
@gilescope gilescope mentioned this pull request Jun 3, 2023
Merged
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@gilescope @ggwpez @nathanwhit
asset-conversion pallet: Generalise integrity test (paritytech#14289)
a2da205 
* integrity test was only working for u32 asset ids.

* cargo fmt

* Update frame/asset-conversion/src/lib.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr left review comments

@jsidorenko jsidorenko jsidorenko approved these changes

@ggwpez ggwpez ggwpez approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gilescope @jsidorenko @bkchr @ggwpez @joepetrowski