This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove unrequired check #14298
Merged
Remove unrequired check #14298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_pool_account function no longer relies on a `_trucating` function, and there is a test in place should someone alter the function to create pool collisions.
gilescope
added
A0-please_review
bkchr
approved these changes
Jun 3, 2023
liamaharon
reviewed
Jun 4, 2023
|
The check is also on lib.rs when it imports the module. It’s nicer if the
check is at the lib.rs level as rustc won’t load that file from disk and
also any changes to that file won’t trigger incremental compilation
dirtying (unless the feature is activated)
…On Sun, 4 Jun 2023 at 11:37, Liam Aharon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In frame/asset-conversion/src/benchmarking.rs
<#14298 (comment)>
:
> -#![cfg(feature = "runtime-benchmarks")]
-
Why's this removed? I notice it exists in most other benchmarking.rs
files.
—
Reply to this email directly, view it on GitHub
<#14298 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEJCAJ6DYUC3JVYDPADQTXJRQNTANCNFSM6AAAAAAYZGZVAQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ggwpez
approved these changes
Jun 4, 2023
There was a problem hiding this comment.
The check is also on lib.rs when it imports the module. It’s nicer if the
check is at the lib.rs level as rustc won’t load that file from disk and
also any changes to that file won’t trigger incremental compilation
dirtying (unless the feature is activated)
Did not know this, thanks!
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 43adad4 |
|
bot merge |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Remove unrequired check The get_pool_account function no longer relies on a `_trucating` function, and there is a test in place should someone alter the function to create pool collisions. * test needed in this case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_pool_accountfunction no longer relies on a_truncatingfunction when creating the account (which could have lead to pool collisions), and there is a test in placeshould someone alter the function in the future to something that created pool collisions.
I don't think this check is helpful any longer and it's now inaccurate as there's now no reason for the account type to be at least u128.
Fixes issues brought to attention in #14289.