Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use set_balance() instead of write_balance() in benchmark #14497

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Use set_balance() instead of write_balance() in benchmark #14497

merged 5 commits into from
Jul 5, 2023

Conversation

jsidorenko
Copy link
Contributor

@jsidorenko jsidorenko added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 3, 2023
@jsidorenko jsidorenko requested review from a team July 3, 2023 12:27
ggwpez
ggwpez approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits.

frame/asset-conversion/src/benchmarking.rs Show resolved Hide resolved
frame/asset-conversion/src/benchmarking.rs Outdated Show resolved Hide resolved
@jsidorenko
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 8c823ec into master Jul 5, 2023
4 checks passed
@paritytech-processbot paritytech-processbot bot deleted the js/fix-asset-conversion-benchmark branch July 5, 2023 10:04
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@jsidorenko @nathanwhit
Use set_balance() instead of write_balance() in benchmark (paritytech…
a897bf2 
…#14497)

* Use set_balance instead of write_balance in benchmark

* Another approach

* Use BalanceOf::<T>::max_value() / 1000

* use a regular div instead of a checked one
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gilescope gilescope gilescope approved these changes

@bkontur bkontur bkontur approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsidorenko @gilescope @bkontur @ggwpez