Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use set_balance() instead of write_balance() in benchmark #14497

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Use set_balance() instead of write_balance() in benchmark #14497

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
353a4e3
Use set_balance instead of write_balance in benchmark
jsidorenko Jul 3, 2023
bb3e8ce
Another approach
jsidorenko Jul 3, 2023
64108c2
Merge branch 'master' into js/fix-asset-conversion-benchmark
jsidorenko Jul 4, 2023
a8bfe0d
Use BalanceOf::<T>::max_value() / 1000
jsidorenko Jul 4, 2023
f95bc2f
use a regular div instead of a checked one
jsidorenko Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions frame/asset-conversion/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,18 @@ use frame_support::{
assert_ok,
storage::bounded_vec::BoundedVec,
traits::{
fungible::{Inspect as InspectFungible, Unbalanced},
fungible::{Inspect as InspectFungible, Mutate as MutateFungible, Unbalanced},
jsidorenko marked this conversation as resolved.
Show resolved Hide resolved
fungibles::{Create, Inspect, Mutate},
},
};
use frame_system::RawOrigin as SystemOrigin;
use sp_runtime::traits::{Bounded, StaticLookup};
use sp_runtime::traits::StaticLookup;
use sp_std::prelude::*;

use crate::Pallet as AssetConversion;

const INITIAL_ASSET_BALANCE: u128 = 1_000_000_000_000;
type AccountIdLookupOf<T> = <<T as frame_system::Config>::Lookup as StaticLookup>::Source;
type BalanceOf<T> =
<<T as Config>::Currency as InspectFungible<<T as frame_system::Config>::AccountId>>::Balance;

fn get_lp_token_id<T: Config>() -> T::PoolAssetId
where
Expand All @@ -55,7 +53,7 @@ where
let caller: T::AccountId = whitelisted_caller();
let caller_lookup = T::Lookup::unlookup(caller.clone());
if let Ok(asset_id) = T::MultiAssetIdConverter::try_convert(asset) {
assert_ok!(T::Currency::write_balance(&caller, BalanceOf::<T>::max_value()));
T::Currency::set_balance(&caller, u32::MAX.into());
ggwpez marked this conversation as resolved.
Show resolved Hide resolved
assert_ok!(T::Assets::create(asset_id.clone(), caller.clone(), true, 1.into()));
assert_ok!(T::Assets::mint_into(asset_id, &caller, INITIAL_ASSET_BALANCE.into()));
}
Expand Down