Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using -d option #770

Merged
merged 10 commits into from
Mar 14, 2023
Merged

Error when using -d option #770

merged 10 commits into from
Mar 14, 2023

Conversation

wirednkod
Copy link
Contributor

@wirednkod wirednkod commented Mar 3, 2023 •
edited
Loading

Fixes #769

@wirednkod wirednkod requested a review from pepoviola March 6, 2023 18:22
@wirednkod wirednkod marked this pull request as ready for review March 7, 2023 08:42
@wirednkod
Copy link
Contributor Author

There is a minor issue concerning the podman - that still makes the -d option fail. It is relative to the permissions of the user which are not the same between the local to the podman directories.
I am not also sure, why we need to create everything locally and then "pass" it to the podman, and not create it inside podman - opinions @pepoviola ?

@pepoviola
Copy link
Collaborator

There is a minor issue concerning the podman - that still makes the -d option fail. It is relative to the permissions of the user which are not the same between the local to the podman directories. I am not also sure, why we need to create everything locally and then "pass" it to the podman, and not create it inside podman - opinions @pepoviola ?

Fixed in the last commit, using podman unshare to change permissions.

@pepoviola pepoviola merged commit 79cbfbb into main Mar 14, 2023
@pepoviola pepoviola deleted the nik-investigate-dir-issue branch March 14, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using -d option
2 participants
@wirednkod @pepoviola