Error when using -d option

javascript/packages/orchestrator/src/network.ts

@@ -153,7 +153,7 @@ export class Network {
   async dumpLogs(showLogPath: boolean = true): Promise<string> {
     const logsPath = this.tmpDir + "/logs";
     // create dump directory in local temp
-    fs.mkdirSync(logsPath);
+    if (!fs.existsSync(logsPath)) fs.mkdirSync(logsPath);
     const paraNodes: NetworkNode[] = Object.values(this.paras).reduce(
       (memo: NetworkNode[], value) => memo.concat(value.nodes),
       [],

javascript/packages/orchestrator/src/orchestrator.ts

@@ -261,7 +261,7 @@ export async function start(
 
     // Check if the chain spec is in raw format
     // Could be if the chain_spec_path was set
-    const chainSpecContent = require(chainSpecFullPathPlain);
+    const chainSpecContent = readAndParseChainSpec(chainSpecFullPathPlain);
     client.chainId = chainSpecContent.id;
 
     const parachainFilesPromiseGenerator = async (parachain: Parachain) => {
@@ -375,7 +375,8 @@ export async function start(
 
     // ensure chain raw is ok
     try {
-      const chainRawContent = require(chainSpecFullPath);
+      const chainsSpecString = fs.readFileSync(chainSpecFullPath).toString();
+      const chainRawContent = JSON.parse(chainsSpecString);
       debug(`Chain name: ${chainRawContent.name}`);
 
       new CreateLogTable({ colWidths: [120], doubleBorder: true }).pushToPrint([
@@ -660,7 +661,6 @@ export async function start(
       // add bootnodes to chain spec
       await addBootNodes(chainSpecFullPath, bootnodes);
       // flush require cache since we change the chain-spec
-      delete require.cache[require.resolve(chainSpecFullPath)];
 
       if (client.providerName === "kubernetes") {
         // cache the chainSpec with bootnodes

javascript/packages/orchestrator/src/providers/k8s/chain-spec.ts

@@ -8,7 +8,7 @@ import { getClient } from "../client";
 import { createTempNodeDef, genNodeDef } from "./dynResourceDefinition";
 const debug = require("debug")("zombie::kube::chain-spec");
 
-const fs = require("fs").promises;
+const { writeFileSync, promises } = require("fs");
 
 export async function setupChainSpec(
   namespace: string,
@@ -21,7 +21,7 @@ export async function setupChainSpec(
   // 2: User provide the chainSpecCommand (without the --raw option)
   const client = getClient();
   if (chainConfig.chainSpecPath) {
-    await fs.copyFile(chainConfig.chainSpecPath, chainFullPath);
+    await promises.copyFile(chainConfig.chainSpecPath, chainFullPath);
   } else {
     if (chainConfig.chainSpecCommand) {
       const { defaultImage, chainSpecCommand } = chainConfig;
@@ -139,7 +139,7 @@ export async function getChainSpecRaw(
       if (result.exitCode === 0 && result.stdout.length > 0) {
         // TODO: remove this debug when we get this fixed.
         debug(result.stdout);
-        fs.writeFileSync(chainFullPath, result.stdout);
+        writeFileSync(chainFullPath, result.stdout);
         isValid = true;
       }
     } catch (_) {}

javascript/packages/orchestrator/src/providers/native/chain-spec.ts

@@ -8,7 +8,7 @@ import { getClient } from "../client";
 import { createTempNodeDef, genNodeDef } from "./dynResourceDefinition";
 const debug = require("debug")("zombie::native::chain-spec");
 
-const fs = require("fs").promises;
+const { readFileSync, promises } = require("fs");
 
 export async function setupChainSpec(
   namespace: string,
@@ -22,7 +22,7 @@ export async function setupChainSpec(
   const client = getClient();
   if (chainConfig.chainSpecPath) {
     // copy file to temp to use
-    await fs.copyFile(chainConfig.chainSpecPath, chainFullPath);
+    await promises.copyFile(chainConfig.chainSpecPath, chainFullPath);
   } else {
     if (chainConfig.chainSpecCommand) {
       const { defaultImage, chainSpecCommand } = chainConfig;
@@ -41,7 +41,7 @@ export async function setupChainSpec(
 
       const podDef = await genNodeDef(namespace, node);
       await client.spawnFromDef(podDef);
-      await fs.copyFile(plainChainSpecOutputFilePath, chainFullPath);
+      await promises.copyFile(plainChainSpecOutputFilePath, chainFullPath);
     }
   }
 }
@@ -90,7 +90,7 @@ export async function getChainSpecRaw(
   // let's add some extra checks here to ensure we are ok.
   let isValid = false;
   try {
-    require(chainFullPath);
+    JSON.parse(readFileSync(chainFullPath).toString());
     isValid = true;
   } catch (e) {
     debug(e);

javascript/packages/orchestrator/src/providers/native/nativeClient.ts

@@ -131,10 +131,17 @@ export class NativeClient extends Client {
       return memo;
     }, memo);
 
-    if (pids.length > 0) {
-      args.push(`kill -9 ${pids.join(" ")}`);
+    const result = await this.runCommand(
+      ["bash", "-c", `ps ax| awk '{print $1}'| grep -E '${pids.join("|")}'`],
+      { allowFail: true },
+    );
+    if (result.exitCode === 0) {
+      const pidsToKill = result.stdout.split("\n");
+      if (pidsToKill.length > 0) {
+        args.push(`kill -9 ${pids.join(" ")}`);
 
-      await this.runCommand(args);
+        await this.runCommand(args);
+      }
     }
   }
 

javascript/packages/orchestrator/src/providers/podman/chain-spec.ts

@@ -8,7 +8,7 @@ import { getClient } from "../client";
 import { createTempNodeDef, genNodeDef } from "./dynResourceDefinition";
 const debug = require("debug")("zombie::podman::chain-spec");
 
-const fs = require("fs").promises;
+const { copyFileSync, readFileSync, promises } = require("fs");
 
 export async function setupChainSpec(
   namespace: string,
@@ -22,7 +22,7 @@ export async function setupChainSpec(
   const client = getClient();
   if (chainConfig.chainSpecPath) {
     // copy file to temp to use
-    await fs.copyFile(chainConfig.chainSpecPath, chainFullPath);
+    copyFileSync(chainConfig.chainSpecPath, chainFullPath);
   } else {
     if (chainConfig.chainSpecCommand) {
       const { defaultImage, chainSpecCommand } = chainConfig;
@@ -46,7 +46,7 @@ export async function setupChainSpec(
       debug("copy file from pod");
 
       const podChainPath = `${client.tmpDir}/${podName}${plainChainSpecOutputFilePath}`;
-      await fs.copyFile(podChainPath, chainFullPath);
+      copyFileSync(podChainPath, chainFullPath);
     }
   }
 }
@@ -103,8 +103,12 @@ export async function getChainSpecRaw(
   let isValid = false;
   try {
     let content = require(chainFullPath);
+    const chainSpecContentTest = readFileSync(chainFullPath);
+    JSON.parse(chainSpecContentTest.toString());
     isValid = true;
-  } catch (_) {}
+  } catch (e) {
+    debug(e);
+  }
 
   if (!isValid) {
     try {
@@ -117,10 +121,12 @@ export async function getChainSpecRaw(
       if (result.exitCode === 0 && result.stdout.length > 0) {
         // TODO: remove this debug when we get this fixed.
         debug(result.stdout);
-        fs.writeFileSync(chainFullPath, result.stdout);
+        promises.writeFileSync(chainFullPath, result.stdout);
         isValid = true;
       }
-    } catch (_) {}
+    } catch (e) {
+      debug(e);
+    }
   }
 
   if (!isValid) throw new Error(`Invalid chain spec raw file generated.`);