Skip to content

fix(dropdown): Delay setting focus on first item to prevent inadvertent scroll #1155

fix(dropdown): Delay setting focus on first item to prevent inadvertent scroll

fix(dropdown): Delay setting focus on first item to prevent inadvertent scroll #1155

Triggered via pull request September 18, 2024 17:29
Status Success
Total duration 7m 19s
Artifacts 1

main.yml

on: pull_request
Matrix: Integration tests
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Lint: packages/react-core/src/components/BackToTop/BackToTop.tsx#L36
The 'toggleVisible' function makes the dependencies of useEffect Hook (at line 74) change on every render. Move it inside the useEffect callback. Alternatively, wrap the definition of 'toggleVisible' in its own useCallback() Hook
Lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L184
React Hook useEffect has a missing dependency: 'focusedDate'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L191
React Hook useEffect has a missing dependency: 'shouldFocus'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L134
React Hook React.useMemo has a missing dependency: 'placeholder.length'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L145
React Hook React.useEffect has a missing dependency: 'dateParse'. Either include it or remove the dependency array. If 'dateParse' changes too often, find the parent component that defines it and wrap that definition in useCallback
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L151
React Hook React.useEffect has missing dependencies: 'applyValidators' and 'valueDate'. Either include them or remove the dependency array
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L162
React Hook React.useEffect has missing dependencies: 'applyValidators', 'dateIsRequired', 'dateParse', 'emptyDateText', 'errorText', 'pristine', and 'textInputFocused'. Either include them or remove the dependency array. If 'dateParse' changes too often, find the parent component that defines it and wrap that definition in useCallback
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L228
React Hook useImperativeHandle has an unnecessary dependency: 'selectOpen'. Either exclude it or remove the dependency array
Lint: packages/react-core/src/components/Drawer/DrawerPanelContent.tsx#L245
Assignments to the 'setInitialVals' variable from inside React Hook React.useCallback will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside React.useCallback
Lint: packages/react-core/src/components/Drawer/DrawerPanelContent.tsx#L261
React Hook React.useCallback has missing dependencies: 'handleControlMove' and 'position'. Either include them or remove the dependency array

Artifacts

Produced during runtime
Name Size
demo-app
941 KB