Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: match declaration and definition signatures #13

Open
wants to merge 1 commit into
base: STABLE-2_1_x_phoenix
Choose a base branch
from

Conversation

badochov
Copy link

JIRA: RTOS-927

Warnings fixed:

 /github/workspace/phoenix-rtos-lwip/lib-lwip/src/api/api_msg.c: In function 'lwip_netconn_do_send':
Warning: /github/workspace/phoenix-rtos-lwip/lib-lwip/src/api/api_msg.c:1598:44: warning: the comparison will always evaluate as 'true' for the address of 'netpacket_hwaddr' will never be NULL [-Waddress]
 1598 |           if (msg->msg.b->netpacket_hwaddr != NULL && msg->msg.b->netpacket_hwaddr_len != 0) {
      |                                            ^~
In file included from lib-lwip/src/include/lwip/api.h:47,
                 from lib-lwip/src/include/lwip/priv/api_msg.h:47,
                 from /github/workspace/phoenix-rtos-lwip/lib-lwip/src/api/api_msg.c:43:
lib-lwip/src/include/lwip/netbuf.h:73:8: note: 'netpacket_hwaddr' declared here
   73 |   u8_t netpacket_hwaddr[ETH_HWADDR_LEN];
      |        ^~~~~~~~~~~~~~~~
 Warning: /github/workspace/phoenix-rtos-lwip/lib-lwip/src/netif/ppp/chap_ms.c:497:32: warning: argument 2 of type 'const u_char[16]' {aka 'const unsigned char[16]'} with mismatched bound [-Warray-parameter=]
497 |                   const u_char PasswordHash[MD4_SIGNATURE_SIZE],
    |                   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/github/workspace/phoenix-rtos-lwip/lib-lwip/src/netif/ppp/chap_ms.c:155:52: note: previously declared as 'const u_char *' {aka 'const unsigned char *'}
155 | static void     ChallengeResponse (const u_char *, const u_char *, u_char[24]);
    |                                                    ^~~~~~~~~~~~~~
Warning: /github/workspace/phoenix-rtos-lwip/lib-lwip/src/netif/ppp/chap_ms.c:875:16: warning: argument 8 of type 'u_char[]' {aka 'unsigned char[]'} with mismatched bound [-Warray-parameter=]
875 |         u_char authResponse[], int authenticator) {
    |         ~~~~~~~^~~~~~~~~~~~~~
/github/workspace/phoenix-rtos-lwip/lib-lwip/src/netif/ppp/chap_ms.c:179:29: note: previously declared as 'u_char[41]' {aka 'unsigned char[41]'}
179 |                   u_char *, u_char[MS_AUTH_RESPONSE_LENGTH+1], int);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant