Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: adapt to gcc 14.2 warnings #97

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Sep 27, 2024

Description

Warnings fixed:

Warning: /github/workspace/phoenix-rtos-lwip/drivers/ephy.c:121:9: warning: 'full_duplex' may be used uninitialized [-Wmaybe-uninitialized]
  121 |         printf("lwip: ephy%u.%u link is %s %uMbps/%s (ctl %04x, status %04x, adv %04x, lpa %04x, pctl %04x,%04x)\n",
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  122 |                 phy->bus, phy->addr, linkup ? "UP  " : "DOWN", speed, full_duplex ? "Full" : "Half",
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  123 |                 bctl, bstat, adv, lpa, pc1, pc2);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/github/workspace/phoenix-rtos-lwip/drivers/ephy.c:104:20: note: 'full_duplex' was declared here
  104 |         int speed, full_duplex;
      |                    ^~~~~~~~~~~

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Copy link

github-actions bot commented Sep 27, 2024

Unit Test Results

7 329 tests   - 396   6 645 ✅  - 365   41m 22s ⏱️ + 4m 13s
  461 suites + 16     672 💤  -  43 
    1 files   ±  0      12 ❌ + 12 

For more details on these failures, see this check.

Results for commit 56af6c1. ± Comparison against base commit b0964a1.

This pull request removes 422 and adds 26 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.in_val
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.invalid_req
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.no_data
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit.ioctl.not_valid_fd
…
flash ‑ sparcv8leon3-generic-qemu:flash
phoenix-rtos-tests/ioctl/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/ioctl/unit
phoenix-rtos-tests/libc/misc ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/libc/misc
phoenix-rtos-tests/libc/stdio ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/libc/stdio
phoenix-rtos-tests/libc/string ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/libc/string
phoenix-rtos-tests/libuuid/unit ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/libuuid/unit
phoenix-rtos-tests/proc/test_thread_rand ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/proc/test_thread_rand
phoenix-rtos-tests/psh/auth ‑ sparcv8leon3-generic-qemu:phoenix-rtos-tests/psh/auth
phoenix-rtos-tests/psh/autocompletion ‑ sparcv8leon3-generic-qemu:phoenix-rtos-tests/psh/autocompletion
phoenix-rtos-tests/psh/cat ‑ sparcv8leon3-generic-qemu:phoenix-rtos-tests/psh/cat
…

♻️ This comment has been updated with latest results.

@badochov badochov force-pushed the badochov/gcc-14.2 branch 2 times, most recently from bfeac7a to 4d365cc Compare October 4, 2024 11:01
* lib-lwip ce151524...aba8a8ea (1):
  > newtif: add message to assert

JIRA: RTOS-927
Comment on lines +122 to 123
phy->bus, phy->addr, linkup ? "UP " : "DOWN", speed, (full_duplex != 0) ? "Full" : "Half",
bctl, bstat, adv, lpa, pc1, pc2);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clang-format-pr] reported by reviewdog 🐶
suggested fix

Suggested change
phy->bus, phy->addr, linkup ? "UP " : "DOWN", speed, (full_duplex != 0) ? "Full" : "Half",
bctl, bstat, adv, lpa, pc1, pc2);
phy->bus, phy->addr, linkup ? "UP " : "DOWN", speed, (full_duplex != 0) ? "Full" : "Half",
bctl, bstat, adv, lpa, pc1, pc2);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant