Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build enhancements #152

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Build enhancements #152

merged 5 commits into from
Sep 4, 2023

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Aug 31, 2023

CI to pass: phoenix-rtos/phoenix-rtos-project#815

Description

  • makes: binary.mk: introduce LOCAL_LDLIBS
  • build: remove exported CLEAN variable
  • makes: build host tools explicitly
    • add global host component to build.sh
    • build host tools by using TARGET=host-generic-pc and common makefiles
      infrastructure
  • makes: reformat Makefile.host
  • make: globally add PROJECT_PATH to the include search path

Motivation and Context

JIRA: CI-334

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

build.sh Show resolved Hide resolved
build.sh Show resolved Hide resolved
# if not already building for host - re-exec with clean env
(env "$ORIG_ENV" TARGET=$_TARGET_FOR_HOST_BUILD ./phoenix-rtos-build/build.sh host)
else
source ./phoenix-rtos-build/build-host-tools.sh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Not following: ./phoenix-rtos-build/build-host-tools.sh: openBinaryFile: does not exist (No such file or directory) SC1091

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Unit Test Results

4 753 tests  ±0   4 240 ✔️ ±0   13m 32s ⏱️ -4s
   234 suites ±0      513 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 5719a4f. ± Comparison against base commit acf0a53.

♻️ This comment has been updated with latest results.

- add global `host` component to build.sh
- build host tools by using TARGET=host-generic-pc and common makefiles
infrastructure

JIRA: CI-334
Makefile.host Show resolved Hide resolved
build.sh Show resolved Hide resolved
@nalajcie nalajcie merged commit 8cff7a2 into master Sep 4, 2023
27 of 28 checks passed
@nalajcie nalajcie deleted the nalajcie/build branch September 4, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants