test PR for build changes #815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2023
nalajcie
force-pushed
the
nalajcie/build
branch
from
b8811da
to
d46bc63
Compare
nalajcie
commented
Aug 31, 2023
.github/workflows/ci-project.yml
Outdated
| @@ -13,7 +13,7 @@ on: | |||
| build_params: | |||
| type: string | |||
| description: "parameters to build.sh script" | |||
| default: 'core fs test project image' # by default don't build ports | |||
| default: 'host core fs test project image' # by default don't build ports | |||
There was a problem hiding this comment.
WARN: rignt now host target was added for each of the CI build target.
Maybe it would be better to:
- create separate CI job for building host utils
- don't build host utils for every target
- (in testing we're using hostutils from docker image anyway)
There was a problem hiding this comment.
the idea (to be implemented after merging all respective changes is to:
- for whole project build host utils only for target
host-generic-pc - introduce separate CI in
phoenix-rtos-hostutils
nalajcie
force-pushed
the
nalajcie/build
branch
from
d46bc63
to
7463aba
Compare
nalajcie
force-pushed
the
nalajcie/build
branch
from
7463aba
to
65562f0
Compare
nalajcie
force-pushed
the
nalajcie/build
branch
from
65562f0
to
a27e14f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR for CI to pass
the idea (to be implemented after merging all respective changes is to:
for whole project build host utils only for target host-generic-pc
introduce separate CI in phoenix-rtos-hostutils
Description
summary of changes:
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment