Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GR716: implement flash driver #258

Merged
merged 1 commit into from
Jul 14, 2023
Merged

GR716: implement flash driver #258

merged 1 commit into from
Jul 14, 2023

Conversation

lukileczo
Copy link
Member

@lukileczo lukileczo commented May 19, 2023 •
edited
Loading

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: sparcv8leon3-gr716-mini.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@lukileczo lukileczo force-pushed the lukileczo/gr716-flash branch 6 times, most recently from bf7583d to 30269a7 Compare May 31, 2023 12:49
@lukileczo lukileczo force-pushed the lukileczo/gr716-flash branch 2 times, most recently from 61b61a1 to 4b78e44 Compare June 21, 2023 13:49
@lukileczo lukileczo marked this pull request as ready for review June 21, 2023 13:49
@lukileczo lukileczo force-pushed the lukileczo/gr716-flash branch 3 times, most recently from 6bde2fd to 4862a95 Compare June 22, 2023 07:47
agkaminski
agkaminski reviewed Jun 22, 2023
View reviewed changes
devices/flash-gr716/flashdrv.c Outdated Show resolved Hide resolved
devices/flash-gr716/flashdrv.c Outdated Show resolved Hide resolved
devices/flash-gr716/flashdrv.c Outdated Show resolved Hide resolved
devices/flash-gr716/flashdrv.c Show resolved Hide resolved
@lukileczo lukileczo force-pushed the lukileczo/gr716-flash branch 3 times, most recently from f55808e to 21402b3 Compare July 11, 2023 07:59
agkaminski
agkaminski reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one place that might be improved, otherwise LGTM

devices/flash-gr716/flashdrv.c Outdated Show resolved Hide resolved
agkaminski
agkaminski reviewed Jul 14, 2023
View reviewed changes
devices/flash-gr716/flashdrv.c Outdated Show resolved Hide resolved
devices/flash-gr716/flashdrv.c Outdated Show resolved Hide resolved
@lukileczo lukileczo force-pushed the lukileczo/gr716-flash branch 2 times, most recently from 1f3a4b3 to 7a365fe Compare July 14, 2023 11:27
agkaminski
agkaminski approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukileczo lukileczo merged commit 1d88209 into master Jul 14, 2023
24 checks passed
@lukileczo lukileczo deleted the lukileczo/gr716-flash branch July 14, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukileczo @agkaminski