Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GR716: Implement plo copy to SRAM #252

Merged
merged 2 commits into from
Jun 22, 2023
Merged

GR716: Implement plo copy to SRAM #252

merged 2 commits into from
Jun 22, 2023

Conversation

lukileczo
Copy link
Member

@lukileczo lukileczo commented May 12, 2023 •
edited
Loading

Description

Motivation and Context

JIRA: RTOS-450

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: sparcv8leon3-gr716-mini

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@lukileczo lukileczo changed the title Implement plo copy to SRAM GR716: Implement plo copy to SRAM May 12, 2023
@lukileczo lukileczo force-pushed the lukileczo/RTOS-450 branch 4 times, most recently from 5352f26 to 4051b29 Compare May 19, 2023 13:58
@lukileczo lukileczo requested a review from agkaminski May 31, 2023 08:07
@lukileczo lukileczo marked this pull request as ready for review June 7, 2023 12:58
agkaminski
agkaminski reviewed Jun 15, 2023
View reviewed changes
hal/sparcv8leon3/_init.S Show resolved Hide resolved
hal/sparcv8leon3/_traps.S Outdated Show resolved Hide resolved
hal/sparcv8leon3/_traps.S Show resolved Hide resolved
hal/sparcv8leon3/gr716/gr716.c Outdated Show resolved Hide resolved
@lukileczo lukileczo force-pushed the lukileczo/RTOS-450 branch 2 times, most recently from 6e878f4 to 720e645 Compare June 21, 2023 13:45
@lukileczo lukileczo mentioned this pull request Jun 21, 2023
Merged
13 tasks
agkaminski
agkaminski approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukileczo lukileczo merged commit 9a488af into master Jun 22, 2023
@lukileczo lukileczo deleted the lukileczo/RTOS-450 branch June 22, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukileczo @agkaminski