This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
move pd scheduler to separated pkg #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glorv
force-pushed
the
pd-mgr
branch
2 times, most recently
from
11fe61a
to
c0be41e
Compare
glorv
changed the title
kennytm
reviewed
Sep 27, 2020
pkg/conn/conn.go
Outdated
| dom *domain.Domain | ||
| storage tikv.Storage | ||
| grpcClis struct { | ||
| PdController *pdutil.PdController |
There was a problem hiding this comment.
could we make it an anonymous field?
Suggested change
| PdController *pdutil.PdController | |
| *pdutil.PdController |
overvenus
approved these changes
Sep 28, 2020
glorv
changed the title
|
/lgtm |
ti-srebot
approved these changes
Sep 28, 2020
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
1 similar comment
|
cherry pick to release-4.0 failed |
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
glorv
added a commit
to glorv/br
that referenced
this pull request
Sep 28, 2020
* move pd scheduler to separate struct * add comments * fix import * fix test * add NewPdController * add missing comment * move pd controller to separated pkg * fix * make PDController in Mgr anonymous
ti-srebot
pushed a commit
that referenced
this pull request
Sep 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Move pd scheduler relates functions from
Mgrto a separated public struct so that we can reuse these logic in lightning and other project.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release Note