restore: disable some pd scheduler during restore #408
Conversation
kennytm
added
the
status/DNM
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
There was a problem hiding this comment.
pingcap/br#532 has been merged. please update the go.mod.
rest LGTM.
glorv
removed
the
status/DNM
| var wg sync.WaitGroup | ||
| // for importer/local backend, we should disable some pd scheduler and change some settings, to | ||
| // make split region and ingest sst more stable | ||
| if rc.cfg.TikvImporter.Backend != config.BackendTiDB { |
There was a problem hiding this comment.
How about make another config to control the schedulers?
There was a problem hiding this comment.
Are there any situations we want to use local/importer backend but still need to enable these schedulers? Since they have big impacts, I think we should always disable them in any case? In cases when we shouldn't disable the schedulers, maybe tidb backend is a proper choice then
There was a problem hiding this comment.
ok, another problem is when lightning exits abnormally after remove these schedulers. next time lightning will reset nothing even it successfully restore data without any errors. so we should follow this tikv/pd#2782, and better to have a way to set the lost config/schedulers back.
|
let's block this on pingcap/br#551. |
|
Both pingcap/br#532 and pingcap/br#551 are merged, could you move this PR forward? |
glorv
added
status/LGT2
What problem does this PR solve?
disable pd scheduler for local/importer backend to make split region and ingest sst files more stable
depends on pingcap/br#532 to be merge first
What is changed and how it works?
Check List
Tests
Side effects
Related changes