Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

bug-fix: fix currentLocation not increase in rows event #1329

Merged
merged 2 commits into from
Dec 10, 2020
Merged

bug-fix: fix currentLocation not increase in rows event #1329

merged 2 commits into from
Dec 10, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Dec 10, 2020 •
edited
Loading

What problem does this PR solve?

row event's currentLocation not update due to #1303
in #1303, we disable handle-error for rows event, but also skip update currentLocation by mistake.

What is changed and how it works?

update currentlocation in handleRowEvents

Check List

Tests

manually test

add more auto test for transaction later.

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix priority/important Major change, requires approval from ≥2 primary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes and removed priority/normal Minor change, requires approval from ≥1 primary reviewer labels Dec 10, 2020
csuzhangxc
csuzhangxc reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Dec 10, 2020
@csuzhangxc csuzhangxc added this to the v2.0.1 milestone Dec 10, 2020
@csuzhangxc csuzhangxc added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Dec 10, 2020
lance6716
lance6716 approved these changes Dec 10, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit 2b134aa into pingcap:master Dec 10, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Dec 10, 2020
@GMHDBJD @ti-srebot
cherry pick pingcap#1329 to release-2.0
ab86e86 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 10, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1330

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Dec 10, 2020
lance6716 added a commit to lance6716/dm that referenced this pull request Dec 10, 2020
@lance6716
*: add test for pingcap#1329 and revert VIEW support for pingcap#1105
f53dd60
@lance6716 lance6716 mentioned this pull request Dec 10, 2020
Merged
csuzhangxc pushed a commit that referenced this pull request Dec 11, 2020
@ti-srebot @GMHDBJD
bug-fix: fix currentLocation not increase in rows event (#1329) (#1330)
8237052 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com>
overvenus
overvenus reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

lance6716 added a commit that referenced this pull request Dec 17, 2020
@lance6716
*: add test for #1329 and add VIEW & EVENT in builtin filter (#1331)
ccda132
@ti-srebot ti-srebot mentioned this pull request Dec 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@overvenus overvenus overvenus left review comments

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/important Major change, requires approval from ≥2 primary reviewers status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@GMHDBJD @ti-srebot @lance6716 @overvenus @csuzhangxc