Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: add test for #1329 and add VIEW & EVENT in builtin filter (#1331) #1343

Merged
merged 1 commit into from
Dec 17, 2020
Merged

*: add test for #1329 and add VIEW & EVENT in builtin filter (#1331) #1343

merged 1 commit into from
Dec 17, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1331 to release-2.0

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 @ti-srebot
cherry pick pingcap#1331 to release-2.0
172e9d8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 17, 2020
Merged
@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Dec 17, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Dec 17, 2020
GMHDBJD
GMHDBJD approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD merged commit 22466f2 into pingcap:release-2.0 Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @lance6716 @GMHDBJD