Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

.*: replace black-white-list by block-allow-list #756

Merged
merged 18 commits into from
Jun 23, 2020
Merged

.*: replace black-white-list by block-allow-list #756

merged 18 commits into from
Jun 23, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

replace black-white-list by block-allow-list

What is changed and how it works?

replace black-white-list by block-allow-list, and also support black-white-list for compatibility

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the dm/dm-ansible
  • Need to be included in the release note

@WangXiangUSTC WangXiangUSTC added the status/WIP This PR is still work in progress label Jun 22, 2020
@WangXiangUSTC WangXiangUSTC added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Jun 22, 2020
@WangXiangUSTC
Copy link
Contributor Author

@baurine all comments addressed in f686cb1 PTAL again

@baurine
Copy link
Contributor

baurine commented Jun 23, 2020

@baurine all comments addressed in f686cb1 PTAL again

LGTM for the frontend part.

GMHDBJD
GMHDBJD reviewed Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 23, 2020
csuzhangxc
csuzhangxc reviewed Jun 23, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about updating tidb-tools to a replaced version (including pingcap/tidb-tools#353)?

tests/all_mode/run.sh Show resolved Hide resolved
tests/dm_syncer/conf/dm-syncer-1.toml Outdated Show resolved Hide resolved
@WangXiangUSTC WangXiangUSTC mentioned this pull request Jun 23, 2020
Merged
2 tasks
@WangXiangUSTC
Copy link
Contributor Author

How about updating tidb-tools to a replaced version (including pingcap/tidb-tools#353)?

I update the version in e2cd417

csuzhangxc
csuzhangxc approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 23, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jun 23, 2020
@WangXiangUSTC WangXiangUSTC merged commit f80b3bc into pingcap:master Jun 23, 2020
@WangXiangUSTC WangXiangUSTC deleted the xiang/block_allow branch June 23, 2020 09:23
@WangXiangUSTC WangXiangUSTC mentioned this pull request Jun 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baurine baurine baurine left review comments

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.
4 participants
@WangXiangUSTC @baurine @csuzhangxc @GMHDBJD