-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter,table-filter: replace blacklist/whitelist by blocklist/allowlist #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
july2993
approved these changes
Jun 13, 2020
overvenus
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zier-one
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kennytm
added a commit
that referenced
this pull request
Jul 8, 2020
kennytm
added a commit
that referenced
this pull request
Jul 8, 2020
kennytm
added a commit
that referenced
this pull request
Jul 9, 2020
* table-filter: implement the new table filter (#341) * table-filter: implement .gitignore-style table filter * table-filter: fix build error Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn> * table-filter: added filter.All() to conveniently make a match-all filter (#347) * table-filter: added filter.All() to conveniently make a match-all filter * table-filter: fix: NewSchemasFilter() should return the public interface * filter,table-filter: replace blacklist/whitelist by blocklist/allowlist (#353) * filter: fix build error Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Replace blacklist/whitelist by blocklist/allowlist in the documentation of filter and table-filter components.
Check List
Tests
Code changes
Side effects
Related changes