Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter,table-filter: replace blacklist/whitelist by blocklist/allowlist #353

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Jun 12, 2020

What problem does this PR solve?

What is changed and how it works?

Replace blacklist/whitelist by blocklist/allowlist in the documentation of filter and table-filter components.

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm merged commit d38eaa2 into master Jun 18, 2020
@kennytm kennytm deleted the kennytm/filter-docs branch June 18, 2020 05:50
kennytm added a commit that referenced this pull request Jul 9, 2020
* table-filter: implement the new table filter (#341)

* table-filter: implement .gitignore-style table filter

* table-filter: fix build error

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>

* table-filter: added filter.All() to conveniently make a match-all filter (#347)

* table-filter: added filter.All() to conveniently make a match-all filter

* table-filter: fix: NewSchemasFilter() should return the public interface

* filter,table-filter: replace blacklist/whitelist by blocklist/allowlist (#353)

* filter: fix build error

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants