Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev, v3.0: add monitoring TiDB in K8s and log collecting #1552

Merged
merged 22 commits into from
Jul 11, 2019
Merged

dev, v3.0: add monitoring TiDB in K8s and log collecting #1552

merged 22 commits into from
Jul 11, 2019

Conversation

AstroProfundis
Copy link
Contributor

What is changed, added or deleted?

  • Add documentation for deploying monitoring system for TiDB on k8s
  • Add documentation for collecting logs for TiDB on k8s
  • Adjust operation guide to point to above docs

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

lilin90
lilin90 requested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When your the content in this PR is ready, please also make the same changes to v3.0.

dev/how-to/maintain/tidb-in-kubernetes/monitoring.md Outdated
@@ -0,0 +1,59 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this file to /how-to/monitor/tidb-in-kubernetes.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should log collecting doc been moved to the same folder as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AstroProfundis Not necessarily. Please keep it in /how-to/maintain/tidb-in-kubernetes/.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this file to /how-to/monitor/tidb-in-kubernetes.md.

dev/how-to/maintain/tidb-in-kubernetes/log-collecting.md Outdated Show resolved Hide resolved
@lilin90 lilin90 changed the title k8s: add docs for monitoring and log collecting on k8s dev, v3.0: add monitoring TiDB in K8s and log collecting Jul 2, 2019
tennix
tennix approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilin90
lilin90 reviewed Jul 3, 2019
View reviewed changes
dev/how-to/maintain/tidb-in-kubernetes/log-collecting.md Outdated Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/log-collecting.md Outdated Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/log-collecting.md Outdated Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/log-collecting.md Outdated Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/log-collecting.md Outdated Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/monitoring.md Outdated Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/monitoring.md Outdated Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/monitoring.md Outdated Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/tidb-cluster.md Outdated Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/tidb-cluster.md Outdated Show resolved Hide resolved
@DanielZhangQD DanielZhangQD mentioned this pull request Jul 9, 2019
Merged
@yikeke
Copy link
Contributor

yikeke commented Jul 10, 2019 •
edited
Loading

Important Update: We have added a markdownlint static check in the CI check to improve the quality of our documentation, so your unclosed PR might fail the CI check now.

First, you should merge master to your branch, so the upstream changes might resolve the issues found by the CI check. Then, click details beside the ci/circleci: lint — Your tests failed on CircleCI message, and you can check the details for the failure and fix all the issues in your PR. It is recommended to install "markdownlint" extension in your VS Code editor, so it will check all potential issues that fail the CI check.

@AstroProfundis If you have any problem with troubleshooting, please consult @yikeke for help. Thanks for your cooperation~

Ref: #1494

@AstroProfundis
Copy link
Contributor Author

@yikeke PTAL

@yikeke
Copy link
Contributor

yikeke commented Jul 10, 2019

@yikeke PTAL

This PR has passed the CI check, PTAL again. @lilin90

lilin90
lilin90 reviewed Jul 11, 2019
View reviewed changes
dev/how-to/maintain/tidb-in-kubernetes/tidb-cluster.md Show resolved Hide resolved
dev/how-to/maintain/tidb-in-kubernetes/monitoring.md Outdated
@@ -0,0 +1,59 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this file to /how-to/monitor/tidb-in-kubernetes.md.

@lilin90
Copy link
Member

lilin90 commented Jul 11, 2019 •
edited
Loading

@AstroProfundis Please address the last comment. That file directory and file name are incorrect. Just keep it consistent with that in v3.0.

@AstroProfundis
Copy link
Contributor Author

@lilin90 PTAL

lilin90
lilin90 approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member

lilin90 commented Jul 11, 2019

I'll add the two new files to TOC.md later.

@lilin90 lilin90 merged commit 40a2417 into pingcap:master Jul 11, 2019
@lilin90 lilin90 mentioned this pull request Jul 12, 2019
Merged
5 tasks
@AstroProfundis AstroProfundis deleted the logging-and-monitoring branch July 12, 2019 03:43
This was referenced Jul 19, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aylei aylei aylei left review comments

@DanielZhangQD DanielZhangQD DanielZhangQD left review comments

@weekface weekface weekface approved these changes

@tennix tennix tennix approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AstroProfundis @CLAassistant @yikeke @lilin90 @weekface @tennix @aylei @DanielZhangQD