Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-in-kubernetes: add cluster operation guide #1239

Merged
merged 5 commits into from
Jul 15, 2019

Conversation

@DanielZhangQD DanielZhangQD changed the title tidb-in-kubernetes: Migrate operation guide to docs repo tidb-in-kubernetes: migrate operation guide to docs repo Jun 19, 2019
@lilin90 lilin90 changed the title tidb-in-kubernetes: migrate operation guide to docs repo tidb-in-kubernetes: add cluster operation guide Jul 2, 2019
@lilin90
Copy link
Member

lilin90 commented Jul 11, 2019

@DanielZhangQD This document was updated by @xiaojingchen in pingcap/docs-cn#1585. Please update it here. Thanks!

@DanielZhangQD
Copy link
Contributor Author

@DanielZhangQD This document was updated by @xiaojingchen in pingcap/docs-cn#1585. Please update it here. Thanks!

@lilin90 The change refers to cluster-configuration.md which is not in docs repo yet, I think we should not update the change now.

@lilin90
Copy link
Member

lilin90 commented Jul 11, 2019

@DanielZhangQD Thanks for your reminder. You can omit that sentence then. When that file is added, we add that link back.

@DanielZhangQD
Copy link
Contributor Author

@lilin90 New commit of porting tidb-operator#612 and docs-cn#1585.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit f745162 into pingcap:master Jul 15, 2019
@DanielZhangQD DanielZhangQD deleted the operation-migration branch July 18, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants