-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev, v3.0: change tidb-cluster deploy doc #1585
dev, v3.0: change tidb-cluster deploy doc #1585
Conversation
mkdir -p /home/tidb/${releaseName} && \ | ||
helm inspect values pingcap/tidb-cluster --version=${chartVersion} > /home/tidb/${releaseName}/values-${releaseName}.yaml | ||
``` | ||
|
||
> **注意:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的“注意”是承接着上文的内容,请一并挪到下面相应的位置上。
mkdir -p /home/tidb/${releaseName} && \ | ||
helm inspect values pingcap/tidb-cluster --version=${chartVersion} > /home/tidb/${releaseName}/values-${releaseName}.yaml | ||
``` | ||
|
||
> **注意:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply Coco's comments.
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. PTAL @DanielZhangQD
Important Update: We have added a markdownlint static check in the CI check to improve the quality of our documentation, so your unclosed PR might fail the CI check now. Click @xiaojingchen If you have any problem with troubleshooting, please consult @yikeke for help. Thanks for your cooperation~ Ref: #1494 |
what does MD031 mean? |
@xiaojingchen It means this rule. |
What is changed, added or deleted?
changed docs:
main fixes: