Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add document for expensive query log #2211

Merged
merged 19 commits into from
Feb 6, 2020

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Feb 5, 2020

What is changed, added or deleted?

What is the related PR or file link(s)?

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 changed the title add document for expensive query log *: add document for expensive query log Feb 5, 2020
@lilin90 lilin90 requested a review from yikeke February 5, 2020 13:43
@lilin90
Copy link
Member

lilin90 commented Feb 5, 2020

@yikeke Please take a language and format review and pay attention to the file name and directory changes. Thanks!

XuHuaiyu and others added 9 commits February 6, 2020 12:02
…-queries.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
…-queries.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
…-queries.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
…-queries.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
…-queries.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
…-queries.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
…-queries.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
…-queries.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
@XuHuaiyu XuHuaiyu requested a review from yikeke February 6, 2020 04:12
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Feb 6, 2020

PTAL @yikeke

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's ready to apply to other versions.

@yikeke yikeke added the v4.0 This PR/issue applies to TiDB v4.0. label Feb 6, 2020
@yikeke yikeke added dev and removed dev v4.0 This PR/issue applies to TiDB v4.0. labels Feb 6, 2020
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Feb 6, 2020

PTAL @yikeke

@XuHuaiyu XuHuaiyu requested a review from yikeke February 6, 2020 06:38
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu merged commit 08369f5 into pingcap:master Feb 6, 2020
@XuHuaiyu XuHuaiyu deleted the expensive_query branch February 6, 2020 09:52
@lilin90 lilin90 added the size/medium Changes of a medium size. label Feb 6, 2020
@@ -1,7 +1,7 @@
---
title: 慢查询日志
category: how-to
aliases: ['/docs-cn/sql/slow-query/']
aliases: ['/docs-cn/sql/slow-query/','/docs-cn/dev/how-to/maintain/identify-slow-queries/']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align this change in pingcap/docs#1804 @toutdesuite

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files are updated. PTAL. @yikeke

@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium Changes of a medium size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants