executor: update the memory usage format in expensive logs #12809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we cherry-pick this commit to release-3.0 and release-3.1 |
XuHuaiyu
added
status/can-merge
I will pick this PR later. |
|
/run-all-tests |
|
@qw4990 merge failed. |
Codecov Report
@@ Coverage Diff @@
## master #12809 +/- ##
===========================================
Coverage 80.1539% 80.1539%
===========================================
Files 465 465
Lines 107200 107200
===========================================
Hits 85925 85925
Misses 14895 14895
Partials 6380 6380 |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
12 tasks
|
It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @qw4990 PTAL. |
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Update the memory usage format in expensive logs to let it can be analyzed by tools easily.
What is changed and how it works?
Before this PR:
mem_max: 1 MB.After this PR:
mem_max: 1048576 Bytes (1 MB).Check List
Tests