Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference/system-databases: add 12 new documents for sql diagnosis #2522

Merged
merged 55 commits into from
Apr 3, 2020
Merged

reference/system-databases: add 12 new documents for sql diagnosis #2522

merged 55 commits into from
Apr 3, 2020

Conversation

reafans
Copy link
Contributor

@reafans reafans commented Mar 19, 2020

What is changed, added or deleted? (Required)

  1. Add the user documentation for the new function sql-diagnosis
  2. Add overview file sql-diagnosis.md
  3. List all sys table in sql-diagnosis.md and add the detail and eg of these sys table in single file

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn added size/large Changes of a large size. v4.0 This PR/issue applies to TiDB v4.0. translation/doing This PR’s assignee is translating this PR. labels Mar 19, 2020
@TomShawn TomShawn self-assigned this Mar 19, 2020
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first round of review


# SQL DIAGNOSIS

SQL 诊断功能是由 TiDB 4.0 引入的新特性,主要用于提升 TiDB 问题定位效率,相较于 4.0 版本之前,不同的信息需要使用不同工具获取的异构方式,
Copy link
Contributor

@TomShawn TomShawn Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

的异构方式是什么意思呢?

Suggested change
SQL 诊断功能是由 TiDB 4.0 引入的新特性,主要用于提升 TiDB 问题定位效率,相较于 4.0 版本之前,不同的信息需要使用不同工具获取的异构方式,
SQL 诊断功能是在 TiDB 4.0 版本中引入的特性,用于提升 TiDB 问题定位的效率。TiDB 4.0 版本以前,用户需要使用不同工具获取以异构的方式获取不同信息。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

意思就是混杂的,指之前的获取方式比较混杂多样。

reference/system-databases/sql-dignosis.md Outdated Show resolved Hide resolved
reference/system-databases/sql-dignosis.md Outdated Show resolved Hide resolved
reference/system-databases/sql-dignosis.md Outdated Show resolved Hide resolved
reference/system-databases/sql-dignosis.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_hardware.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_hardware.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_hardware.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_hardware.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_hardware.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first round of review

reference/system-databases/cluster_info.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_info.md Outdated Show resolved Hide resolved

* TYPE:节点类型,目前节点的类型为 pd/tikv/tidb,节点类型始终为小写
* INSTANCE:实例地址,始终为 IP:PORT 格式的字符串
* STATUS_ADDRESS:HTTP API 服务地址,部分 tikv-ctl / pd-ctl / tidb-ctl 命令会使用到 HTTP API,会使用这个地址,用户也可以通过这个地址获取一些额外的集群信息,具体 HTTP API 参考官方文档
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可否提供一下 HTTP API 官方文档的链接?

Suggested change
* STATUS_ADDRESS:HTTP API 服务地址,部分 tikv-ctl / pd-ctl / tidb-ctl 命令会使用到 HTTP API,会使用这个地址,用户也可以通过这个地址获取一些额外的集群信息,具体 HTTP API 参考官方文档
* `STATUS_ADDRESS`:HTTP API 的服务地址。部分 tikv-ctl / pd-ctl / tidb-ctl 命令会使用到 HTTP API 和该地址。用户也可以通过该地址获取一些额外的集群信息,详情可参考 HTTP API 官方文档。

reference/system-databases/cluster_info.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_info.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_log.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_log.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_log.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_log.md Outdated Show resolved Hide resolved
reference/system-databases/cluster_log.md Outdated Show resolved Hide resolved
crazycs520 and others added 6 commits March 25, 2020 15:45
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
TOC.md Outdated Show resolved Hide resolved
reference/system-databases/cluster-config.md Show resolved Hide resolved
reference/system-databases/cluster-config.md Show resolved Hide resolved
@TomShawn TomShawn changed the title reference/system-databases: add sql-diagnosis user documentation reference/system-databases: add 12 new documents for sql diagnosis Apr 2, 2020
TOC.md Outdated
@@ -247,6 +247,18 @@
+ 系统数据库
- [`mysql`](/reference/system-databases/mysql.md)
- [`information_schema`](/reference/system-databases/information-schema.md)
+ [`sql-diagnosis`](/reference/system-databases/sql-diagnosis.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PingCAP website does not support this kind of link (link of an item that has sub-items).

@kissmydb
Copy link
Contributor

kissmydb commented Apr 3, 2020

LGTM

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 6454faf into pingcap:master Apr 3, 2020
@reafans reafans deleted the sql-dignosis branch April 14, 2020 05:47
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 15, 2020
@reafans reafans mentioned this pull request Apr 15, 2020
5 tasks
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
…ingcap#2522)

* add sql-dignosis

* fmt

* fix lint

* fix lint

* split the sql-dignosis doc

* refine doc

* fix lint

* add meta info

* add æ�sql copy

* refine doc

* Update reference/system-databases/sql-dignosis.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/sql-dignosis.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/sql-dignosis.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/sql-dignosis.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/cluster_hardware.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/cluster_hardware.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/cluster_hardware.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/cluster_info.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/cluster_info.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/sql-dignosis.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/sql-dignosis.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/cluster_info.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/sql-dignosis.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/cluster_info.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/cluster_log.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update reference/system-databases/cluster_hardware.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* address comment

* refine doc

* refine punctuations and wording

* add more docs

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* Update reference/system-databases/sql-dignosis.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Update reference/system-databases/sql-dignosis.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* add sys tables to TOC

* fix lint

* Update reference/system-databases/sql-diagnosis.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* update metrics_schema docs

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* add reference links and change file names

* fix dead links

* Update reference/system-databases/cluster-config.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Update TOC.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Delete SELECT GREATEST(t1.avg_value,.sql

* reference: add summaries for newly added docs

* toc: fix a link placement issue

Co-authored-by: crazycs <crazycs520@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <1135243111@qq.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/large Changes of a large size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants