-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reference/system-databases: add 12 new documents for sql diagnosis #2522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first round of review
|
||
# SQL DIAGNOSIS | ||
|
||
SQL 诊断功能是由 TiDB 4.0 引入的新特性,主要用于提升 TiDB 问题定位效率,相较于 4.0 版本之前,不同的信息需要使用不同工具获取的异构方式, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
的异构方式
是什么意思呢?
SQL 诊断功能是由 TiDB 4.0 引入的新特性,主要用于提升 TiDB 问题定位效率,相较于 4.0 版本之前,不同的信息需要使用不同工具获取的异构方式, | |
SQL 诊断功能是在 TiDB 4.0 版本中引入的特性,用于提升 TiDB 问题定位的效率。TiDB 4.0 版本以前,用户需要使用不同工具获取以异构的方式获取不同信息。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
意思就是混杂的,指之前的获取方式比较混杂多样。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first round of review
|
||
* TYPE:节点类型,目前节点的类型为 pd/tikv/tidb,节点类型始终为小写 | ||
* INSTANCE:实例地址,始终为 IP:PORT 格式的字符串 | ||
* STATUS_ADDRESS:HTTP API 服务地址,部分 tikv-ctl / pd-ctl / tidb-ctl 命令会使用到 HTTP API,会使用这个地址,用户也可以通过这个地址获取一些额外的集群信息,具体 HTTP API 参考官方文档 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可否提供一下 HTTP API 官方文档的链接?
* STATUS_ADDRESS:HTTP API 服务地址,部分 tikv-ctl / pd-ctl / tidb-ctl 命令会使用到 HTTP API,会使用这个地址,用户也可以通过这个地址获取一些额外的集群信息,具体 HTTP API 参考官方文档 | |
* `STATUS_ADDRESS`:HTTP API 的服务地址。部分 tikv-ctl / pd-ctl / tidb-ctl 命令会使用到 HTTP API 和该地址。用户也可以通过该地址获取一些额外的集群信息,详情可参考 HTTP API 官方文档。 |
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
TOC.md
Outdated
@@ -247,6 +247,18 @@ | |||
+ 系统数据库 | |||
- [`mysql`](/reference/system-databases/mysql.md) | |||
- [`information_schema`](/reference/system-databases/information-schema.md) | |||
+ [`sql-diagnosis`](/reference/system-databases/sql-diagnosis.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PingCAP website does not support this kind of link (link of an item that has sub-items).
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ingcap#2522) * add sql-dignosis * fmt * fix lint * fix lint * split the sql-dignosis doc * refine doc * fix lint * add meta info * add æ�sql copy * refine doc * Update reference/system-databases/sql-dignosis.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/sql-dignosis.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/sql-dignosis.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/sql-dignosis.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/cluster_hardware.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/cluster_hardware.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/cluster_hardware.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/cluster_info.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/cluster_info.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/sql-dignosis.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/sql-dignosis.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/cluster_info.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/sql-dignosis.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/cluster_info.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/cluster_log.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update reference/system-databases/cluster_hardware.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment * refine doc * refine punctuations and wording * add more docs Signed-off-by: crazycs520 <crazycs520@gmail.com> * Update reference/system-databases/sql-dignosis.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> * Update reference/system-databases/sql-dignosis.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> * add sys tables to TOC * fix lint * Update reference/system-databases/sql-diagnosis.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * update metrics_schema docs Signed-off-by: crazycs520 <crazycs520@gmail.com> * add reference links and change file names * fix dead links * Update reference/system-databases/cluster-config.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> * Update TOC.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> * Delete SELECT GREATEST(t1.avg_value,.sql * reference: add summaries for newly added docs * toc: fix a link placement issue Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: TomShawn <1135243111@qq.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?