Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference/system-databases: add 3 cluster tables (2) (#2212) #2359

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 21, 2020

cherry-pick #2212 to release-4.0


What is changed, added or deleted? (Required)

Add the cluster_load, cluster_systeminfo and cluster_log system tables.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

* reference/system-databases: add 3 cluster tables (2)

* replace node with instance and address comments

* change field name

* add `sql` to results

Co-authored-by: Lilian Lee <lilin@pingcap.com>
@sre-bot sre-bot added size/large Changes of a large size. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. v4.0 This PR/issue applies to TiDB v4.0. labels Apr 21, 2020
@sre-bot sre-bot requested review from lilin90 and reafans April 21, 2020 08:18
@reafans
Copy link
Contributor

reafans commented Apr 21, 2020

LGTM

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 4f7f533 into pingcap:release-4.0 Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/large Changes of a large size. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants