Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh: update doc for deploy tidb cluster on ack with cr #30

Merged
merged 2 commits into from
Mar 24, 2020
Merged

zh: update doc for deploy tidb cluster on ack with cr #30

merged 2 commits into from
Mar 24, 2020

Conversation

DanielZhangQD
Copy link
Contributor

What is changed, added or deleted? (Required)

deploy tidb cluster on ack with cr

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version, including v1.1 changes for now)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@Yisaer
Copy link
Contributor

Yisaer commented Mar 23, 2020

Do we need to edit the terraform script for aliyun in operator repo first?

@DanielZhangQD
Copy link
Contributor Author

Do we need to edit the terraform script for aliyun in operator repo first?

It's done in pingcap/tidb-operator#2012.

ran-huang
ran-huang reviewed Mar 24, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

zh/deploy-on-alibaba-cloud.md Show resolved Hide resolved
zh/deploy-on-alibaba-cloud.md Show resolved Hide resolved
@ran-huang ran-huang added priority/P2 The issue has P2 priority. translation/welcome Waits for a contributor to translate this PR to docs-tidb-operator/zh or docs-tidb-operator/en. labels Mar 24, 2020
@DanielZhangQD
Copy link
Contributor Author

@ran-huang comments addressed, PTAL.

@ran-huang ran-huang changed the title deploy tidb cluster on ack with cr zh: update doc for deploy tidb cluster on ack with cr Mar 24, 2020
@ran-huang ran-huang merged commit cd238ff into pingcap:master Mar 24, 2020
@ran-huang ran-huang self-assigned this Mar 24, 2020
@ran-huang ran-huang added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR to docs-tidb-operator/zh or docs-tidb-operator/en. labels Mar 24, 2020
@ran-huang ran-huang mentioned this pull request Mar 28, 2020
Merged
2 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 29, 2020
@sre-bot sre-bot mentioned this pull request Mar 30, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@Yisaer Yisaer Yisaer approved these changes

@weekface weekface Awaiting requested review from weekface

@cofyc cofyc Awaiting requested review from cofyc

Assignees

@ran-huang ran-huang

Labels
priority/P2 The issue has P2 priority. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielZhangQD @Yisaer @ran-huang