en: update doc for deploying TiDB cluster on ACK #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran-huang
added
translation/from-zh
| @@ -334,34 +421,6 @@ You can customize this script. For example, you can remove the `module "bastion" | |||
| > | |||
| > You can copy the `deploy/aliyun` directory. But you cannot copy a directory on which the `terraform apply` operation is currently performed. In this case, it is recommended to clone the repository again and then copy it. | |||
|
|
|||
| ## Destroy | |||
There was a problem hiding this comment.
Please keep this section here, no need to move to the front.
There was a problem hiding this comment.
This is to keep it consistent with the Chinese doc. Please confirm whether we should move it.
Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
|
@DanielZhangQD PTAL again, thanks! |
ran-huang
added
the
needs-cherry-pick-release-1.1
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
|
@yikeke @DanielZhangQD PTAL |
sre-bot
pushed a commit
to sre-bot/docs-tidb-operator
that referenced
this pull request
Mar 30, 2020
* en: update doc for deploying TiDB cluster on ACK * Apply suggestions from Daniel Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> * address comments from Daniel * Apply suggestions from code review Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> * address comments from Coco Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * move the destroy section Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
2 tasks
|
cherry pick to release-1.1 in PR #105 |
DanielZhangQD
added a commit
that referenced
this pull request
Mar 30, 2020
* en: update doc for deploying TiDB cluster on ACK * Apply suggestions from Daniel Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> * address comments from Daniel * Apply suggestions from code review Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> * address comments from Coco Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * move the destroy section Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update doc for deploying TiDB cluster on Alibaba cloud.
Which TiDB Operator version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?