Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support APPROX_PERCENTILE function #1002

Merged
merged 5 commits into from
Sep 4, 2020

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Sep 1, 2020

What problem does this PR solve?

Support parsing APPROX_PERCENTILE function. pingcap/tidb#19405

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Add function

Related changes

  • Need to cherry-pick to the release branch

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Sep 1, 2020
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Sep 3, 2020
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Sep 3, 2020
@tangenta
Copy link
Contributor

tangenta commented Sep 3, 2020

/run-all-tests

1 similar comment
@leiysky
Copy link
Contributor Author

leiysky commented Sep 4, 2020

/run-all-tests

@leiysky leiysky merged commit 39e9c7b into pingcap:master Sep 4, 2020
@leiysky leiysky deleted the feature/support-approx_percentile branch September 4, 2020 06:42
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
* support approx_percentile function

* update

Co-authored-by: kennytm <kennytm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants