pump: Add support to stop write at a limit avaliable space #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
IANTHEREAL
reviewed
Jun 24, 2019
| @@ -30,6 +30,12 @@ pd-urls = "http://127.0.0.1:2379" | |||
| # [storage] | |||
| # Set to `true` (default) for best reliability, which prevents data loss when there is a power failure. | |||
| # sync-log = true | |||
|
|
|||
| # stop write when disk available space less then the configured size | |||
| # 42 MB -> 42000000, 42 mib -> 44040192 | |||
There was a problem hiding this comment.
one gib is too small, use 10% or 10 gib is better
There was a problem hiding this comment.
it may be annoying to set such a limit in a test or development env, how about default 0 and set
10 gib if deployed by ansible ?
There was a problem hiding this comment.
if so, use 10% is better, right?
There was a problem hiding this comment.
update to be 10 gib in ac51fc0
IANTHEREAL
reviewed
Jun 24, 2019
|
Rest LGTM . |
csuzhangxc
reviewed
Jun 24, 2019
|
/run-all-tests |
|
LGTM |
|
@suzaku PTAL |
csuzhangxc
reviewed
Jun 26, 2019
|
/run-all-tests |
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Jul 1, 2019
Default set it 10 gib
ericsyh
pushed a commit
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
pump: Add support to stop write at a limit avaliable space
What is changed and how it works?
Add a configuration to stop writes at a limit available space size.
Check List
Tests
use
ddmake space less than configured size -> write failed -> delete file make enough space -> write succesCode changes
Side effects
Related changes
tidb-ansiblerepository