Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.1] pump: Add support to stop write at a limit avaliable space (#647) #659

Merged
merged 3 commits into from
Jul 2, 2019

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Jul 1, 2019

Default set it 10 gib

What problem does this PR solve?

cherry-pick #647

Add a configuration to stop writes at a limit available space size.

What is changed and how it works?

Check List

Tests

Code changes

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku
Copy link
Contributor

suzaku commented Jul 2, 2019

/run-all-tests

@ericsyh
Copy link
Contributor

ericsyh commented Jul 2, 2019

@suzaku @WangXiangUSTC PTAL

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993
Copy link
Contributor Author

july2993 commented Jul 2, 2019

/run-all-tests

@kennytm
Copy link
Contributor

kennytm commented Jul 2, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1

@july2993
Copy link
Contributor Author

july2993 commented Jul 2, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1

@ericsyh ericsyh merged commit 5ba5f7b into pingcap:release-2.1 Jul 2, 2019
@july2993 july2993 deleted the hjh/pick_space branch July 2, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants