Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine store location, add zoom and pan #772

Merged
merged 13 commits into from
Oct 27, 2020

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Oct 19, 2020

close #737

What did:

  • Disable auto-scale when resizing store location tree component (cancel use viewbox)
  • Add zoom and pan support for store location tree component

Screenshot:

1

Zoom and pan effect on the original component (auto-scale when resizing), just for comparison:

2

TODO:

  • add reset button

3

@baurine baurine marked this pull request as draft October 20, 2020 01:19
@baurine baurine marked this pull request as ready for review October 20, 2020 05:37
@baurine
Copy link
Collaborator Author

baurine commented Oct 21, 2020

@breeswish PTAL when you're free, thanks!

@breezewish breezewish merged commit 6a179d5 into pingcap:master Oct 27, 2020
@breezewish
Copy link
Member

breezewish commented Oct 27, 2020

Looks like there is a bug that the canvas is not extended to the full screen:

image

Also it is better to always display the hint that user can use "Ctrl+Scroll"? In my case, although I have seen the "?" icon, I didn't clicked it :) and found that it is not operational..

@breezewish
Copy link
Member

BTW the refresh button doesn't refresh. Instead it reset positions. Maybe we can add reload functionality into it? (I didn't find a proper icon for reset but not reload..)

@baurine baurine deleted the refine-store-location branch October 28, 2020 00:36
@baurine
Copy link
Collaborator Author

baurine commented Oct 28, 2020

BTW the refresh button doesn't refresh. Instead it reset positions. Maybe we can add reload functionality into it? (I didn't find a proper icon for reset but not reload..)

It's supposed to a reset button... but it is true we can add a reload function as well, will do it.

@breezewish
Copy link
Member

@baurine Yes, it's a reset button. But the icon is exactly the same as a refresh button. User won't know it's reset instead of refresh.

@breezewish
Copy link
Member

To avoid losing track, I opened #801 for issues described in #772 (comment)

@baurine
Copy link
Collaborator Author

baurine commented Nov 20, 2020

To avoid losing track, I opened #801 for issues described in #772 (comment)

Got, thank you!

breezewish added a commit that referenced this pull request Nov 26, 2020
* misc: Increase ulimit to 65535 for test env (#756)
* test: Fix frontend CI (#752)
* ui: fix dayjs i18n (#755)
* ui: handle error globally (#757)
* statement, slow_query: support all fields in list page (#749)
* ui: memorize expand/collapse full text in detail pages (#775)
* ui: break loop dependencies (#771)
* ui: fix browser compatibility check (#776)
* ui: Refine store location, add zoom and pan (#772)
* ui: show disk usage information for statement and slow query (#777)
* ui: use qps instead of ops (#786)
* statement: support export (#778)
*: Fix slow query and start_ts not working in some cases (#793)
* ui: fix errors doesn't display (#794)
* ui: fix the error message doesn't show correct (#799)
* slow_queries: support export (#792)
* ui: add MySqlFormatter to customize the sql formatter (#805)
*: fix query statement detail error cause by round (#806)
* ui: copy original content instead of formatted content for CopyLink (#802)
* add min height of topology canvas (#804)
* metrics: Support customize Prometheus address (#808)
* clusterinfo: Refine (#815)
* ui: Open statement and slow log in new tab (#816)
* ui: add more time field for slow query detail page (#810)
* slowlog: Improve descriptions (#817)
* build: add action to check release-version is changed for release branch
* Release v2020.11.26.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zoom and pan to store topology
3 participants